Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 513323002: Service worker fixups for scoped_refptr operator T* removal. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
michaeln, falken
CC:
chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Service worker fixups for scoped_refptr operator T* removal. BUG=110610 Committed: https://crrev.com/62c7cf8498798e5695556bb1e7fcae7f314b79eb Cr-Commit-Position: refs/heads/master@{#292595}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M content/browser/service_worker/service_worker_cache_storage_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + michaeln@chromium.org
6 years, 3 months ago (2014-08-28 18:12:50 UTC) #1
dcheng
Manual fixups that the automated tool opted not to handle (and several fixes for code ...
6 years, 3 months ago (2014-08-28 18:12:50 UTC) #2
falken
falken@chromium.org changed reviewers: + falken@chromium.org
6 years, 3 months ago (2014-08-29 08:14:23 UTC) #3
falken
rs/lgtm
6 years, 3 months ago (2014-08-29 08:14:23 UTC) #4
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-29 08:14:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/513323002/20001
6 years, 3 months ago (2014-08-29 08:15:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c2bf0bc91303f8a8e6d6a8405395b9963b720276
6 years, 3 months ago (2014-08-29 09:00:48 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:07:18 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62c7cf8498798e5695556bb1e7fcae7f314b79eb
Cr-Commit-Position: refs/heads/master@{#292595}

Powered by Google App Engine
This is Rietveld 408576698