content/browser/service_worker/service_worker_provider_host.cc - Issue 513323002: Service worker fixups for scoped_refptr operator T* removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 513323002: Service worker fixups for scoped_refptr operator T* removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_cache_unittest.cc ('k') | content/browser/service_worker/service_worker_register_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_provider_host.cc

diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc

index 8e1d43ccc8a8518986d60fa0caec93eb819b32c3..bd0c5ea3197e310de114dc2618f42abc0db0618d 100644

--- a/content/browser/service_worker/service_worker_provider_host.cc

+++ b/content/browser/service_worker/service_worker_provider_host.cc

@@ -74,7 +74,7 @@ void ServiceWorkerProviderHost::UpdatePotentialControllees(

ServiceWorkerVersion* active_version) {

if (installing_version != installing_version_.get()) {

scoped_refptr<ServiceWorkerVersion> previous_version = installing_version_;

- if (previous_version)

+ if (previous_version.get())

previous_version->RemovePotentialControllee(this);

if (installing_version)

installing_version->AddPotentialControllee(this);

@@ -83,7 +83,7 @@ void ServiceWorkerProviderHost::UpdatePotentialControllees(

if (waiting_version != waiting_version_.get()) {

scoped_refptr<ServiceWorkerVersion> previous_version = waiting_version_;

- if (previous_version)

+ if (previous_version.get())

previous_version->RemovePotentialControllee(this);

if (waiting_version)

waiting_version->AddPotentialControllee(this);

@@ -92,7 +92,7 @@ void ServiceWorkerProviderHost::UpdatePotentialControllees(

if (active_version != active_version_.get()) {

scoped_refptr<ServiceWorkerVersion> previous_version = active_version_;

- if (previous_version)

+ if (previous_version.get())

previous_version->RemovePotentialControllee(this);

if (active_version)

active_version->AddPotentialControllee(this);