Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 513213002: Generate some intrinsics using our IR. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intrinsifier_arm.cc
===================================================================
--- runtime/vm/intrinsifier_arm.cc (revision 39651)
+++ runtime/vm/intrinsifier_arm.cc (working copy)
@@ -400,50 +400,6 @@
}
-void Intrinsifier::Uint8ArrayGetIndexed(Assembler* assembler) {
- Label fall_through;
- __ ldr(R0, Address(SP, + 0 * kWordSize)); // Index.
- __ ldr(R1, Address(SP, + 1 * kWordSize)); // Array.
- __ tst(R0, Operand(kSmiTagMask));
- __ b(&fall_through, NE); // Index is not a smi, fall through.
-
- // Range check.
- __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
- __ cmp(R0, Operand(R6));
- __ b(&fall_through, CS);
-
- __ SmiUntag(R0);
- __ AddImmediate(R1, TypedData::data_offset() - kHeapObjectTag);
- __ ldrb(R0, Address(R1, R0));
- __ SmiTag(R0);
- __ Ret();
- __ Bind(&fall_through);
-}
-
-
-void Intrinsifier::ExternalUint8ArrayGetIndexed(Assembler* assembler) {
- Label fall_through;
-
- __ ldr(R0, Address(SP, + 0 * kWordSize)); // Index.
- __ ldr(R1, Address(SP, + 1 * kWordSize)); // Array.
- __ tst(R0, Operand(kSmiTagMask));
- __ b(&fall_through, NE); // Index is not a smi, fall through.
-
- // Range check.
- __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
- __ cmp(R0, Operand(R6));
- __ b(&fall_through, CS);
-
- __ LoadFromOffset(kWord, R1, R1,
- ExternalTypedData::data_offset() - kHeapObjectTag);
- __ SmiUntag(R0);
- __ ldrb(R0, Address(R1, R0));
- __ SmiTag(R0);
- __ Ret();
- __ Bind(&fall_through);
-}
-
-
void Intrinsifier::Float64ArrayGetIndexed(Assembler* assembler) {
if (!TargetCPUFeatures::vfp_supported()) {
return;

Powered by Google App Engine
This is Rietveld 408576698