No need to release resources in destructor of CPDF_ShadingObject

core/src/fpdfapi/fpdf_page/fpdf_page.cpp

Index: core/src/fpdfapi/fpdf_page/fpdf_page.cpp
diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page.cpp
index 6d3cf2978509d872e45ee3421611788b30040cfe..590a01aa6dbeeacadd403467ce9499f7505e68d5 100644
--- a/core/src/fpdfapi/fpdf_page/fpdf_page.cpp
+++ b/core/src/fpdfapi/fpdf_page/fpdf_page.cpp
@@ -606,10 +606,6 @@ CPDF_ShadingObject::CPDF_ShadingObject()
 }
 CPDF_ShadingObject::~CPDF_ShadingObject()
 {
-    CPDF_ShadingPattern* pShading = m_pShading;
-    if (pShading && pShading->m_pDocument) {
-        pShading->m_pDocument->GetPageData()->ReleasePattern(pShading->m_pShadingObj);

[jun_fang, 2014/08/28 16:38:14]

Maybe you can save a reference to document rather than getting it by m_pShading.
Then you can call the function of IsForceClear() in CPDF_DocPageData to check
whether the resource is forced to release. More details, please refer to
https://codereview.chromium.org/477323002/.

[Bo Xu, 2014/08/28 17:07:24]

Since we ensure to do forced clear on Patterns in CPDF_DocPageData::Clear, so I
guess we don't really need to check the status here.

-    }
 }
 void CPDF_ShadingObject::CopyData(const CPDF_PageObject* pSrc)
 {