No need to release resources in destructor of CPDF_ShadingObject

core/src/fpdfapi/fpdf_page/fpdf_page.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "pageint.h"
 void CPDF_PageObject::Release()
@@ skipping 588 matching lines @@
     m_TextState = TextState;
     CalcPositionData(NULL, NULL, 0);
 }
 CPDF_ShadingObject::CPDF_ShadingObject()
 {
     m_pShading = NULL;
     m_Type = PDFPAGE_SHADING;
 }
 CPDF_ShadingObject::~CPDF_ShadingObject()
 {
-    CPDF_ShadingPattern* pShading = m_pShading;
-    if (pShading && pShading->m_pDocument) {
-        pShading->m_pDocument->GetPageData()->ReleasePattern(pShading->m_pShadingObj);

[jun_fang, 2014/08/28 16:38:14]

Maybe you can save a reference to document rather than getting it by m_pShading.
Then you can call the function of IsForceClear() in CPDF_DocPageData to check
whether the resource is forced to release. More details, please refer to
https://codereview.chromium.org/477323002/.

[Bo Xu, 2014/08/28 17:07:24]

Since we ensure to do forced clear on Patterns in CPDF_DocPageData::Clear, so I
guess we don't really need to check the status here.

-    }
 }
 void CPDF_ShadingObject::CopyData(const CPDF_PageObject* pSrc)
 {
     CPDF_ShadingObject* pSrcObj = (CPDF_ShadingObject*)pSrc;
     m_pShading = pSrcObj->m_pShading;
     if (m_pShading && m_pShading->m_pDocument) {
         CPDF_DocPageData* pDocPageData = m_pShading->m_pDocument->GetPageData();
         m_pShading = (CPDF_ShadingPattern*)pDocPageData->GetPattern(m_pShading->m_pShadingObj, m_pShading->m_bShadingObj, &m_pShading->m_ParentMatrix);
     }
     m_Matrix = pSrcObj->m_Matrix;
@@ skipping 412 matching lines @@
     matrix = m_PageMatrix;
     matrix.Concat(display_matrix);
 }
 CPDF_ParseOptions::CPDF_ParseOptions()
 {
     m_bTextOnly = FALSE;
     m_bMarkedContent = TRUE;
     m_bSeparateForm = TRUE;
     m_bDecodeInlineImage = FALSE;
 }