Chromium Code Reviews Chromium Code Reviews
Issue
513053003:
Made Blink aware of top controls offset (Blink-side) (Closed)
DescriptionMade Blink aware of top controls offset (Blink-side)
Added all the plumbing to make Blink aware of the top controls position
and how its viewport has been resized as a result. This CL adds all the
machinery and plumbing but does not yet connect main-thread scrolls to
the top controls. This is needed to support scrolling the top controls
during slow-scrolls as well as correct viewport behavior in the virtual
viewport pinch-to-zoom.
The machinery for top controls now includes two values:
top_controls_layout_height: The amount that the viewport was shrunk to
accommodate the top controls. This is updated only during a layout that
causes a viewport resize (i.e. RenderWidget::OnResize). The compositor
needs this to know how much the viewport layer has already been resized
by Blink.
top_controls_content_offset: The amount that the top controls are showing.
This will be the same as top_controls_layout_height right after a viewport
resize, but will diverge since the top controls will move without
immediately causing a RenderWidget resize.
Blink now keeps track of the top controls "content offset", which is the
distance the content is offset from the top of the screen due to top
controls. It receives updates to this value from the Impl thread during
a commit and echos them back to the compositor.
On the compositor side, the top controls layout height is moved into the
LayerTreeImpl. This is necessary since a commit will change the viewport
layer's size on the pending tree. Keeping it in LayerTreeHostImpl meant
that, until the pending tree was activated, the top controls layout height
corresponded to the viewport bounds in the pending tree. This was causing
flickering as the viewport container was the incorrect size for a short
time. The compositor also keeps track of the top controls content offset
value. The top controls offset uses the same model as page scale, keeping
an offset (the value as known by the main thread), a delta from the main
thread's value, and a sent_delta to keep track of what has been sent to
the main thread.
See: https://codereview.chromium.org/511253003 for Chromium-side patch.
BUG=333143
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181527
Patch Set 1 #Patch Set 2 : #Patch Set 3 : Added top_controls_content_offset #
Total comments: 6
Patch Set 4 : Review Feedback #
Total comments: 2
Patch Set 5 : Prepared patch to land cleanly before Chromium side #Patch Set 6 : Rebased #Patch Set 7 : Rebase #
Messages
Total messages: 22 (9 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
