Made Blink aware of top controls offset (Blink-side)

Source/web/WebViewImpl.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 73 matching lines @@
     , public PageWidgetEventHandler {
 public:
     static WebViewImpl* create(WebViewClient*);
 
     // WebWidget methods:
     virtual void close() OVERRIDE;
     virtual WebSize size() OVERRIDE;
     virtual void willStartLiveResize() OVERRIDE;
     virtual void resize(const WebSize&) OVERRIDE;
     virtual void resizePinchViewport(const WebSize&) OVERRIDE;
+    virtual void setTopControlsContentOffset(float) OVERRIDE;
     virtual void willEndLiveResize() OVERRIDE;
     virtual void willEnterFullScreen() OVERRIDE;
     virtual void didEnterFullScreen() OVERRIDE;
     virtual void willExitFullScreen() OVERRIDE;
     virtual void didExitFullScreen() OVERRIDE;
 
     virtual void beginFrame(const WebBeginFrameArgs&) OVERRIDE;
 
     virtual void layout() OVERRIDE;
     virtual void paint(WebCanvas*, const WebRect&) OVERRIDE;
 #if OS(ANDROID)
     virtual void paintCompositedDeprecated(WebCanvas*, const WebRect&) OVERRIDE;
 #endif
     virtual void compositeAndReadbackAsync(WebCompositeAndReadbackAsyncCallback*) OVERRIDE;
     virtual bool isTrackingRepaints() const OVERRIDE;
     virtual void themeChanged() OVERRIDE;
     virtual bool handleInputEvent(const WebInputEvent&) OVERRIDE;
     virtual void setCursorVisibilityState(bool isVisible) OVERRIDE;
     virtual bool hasTouchEventHandlersAt(const WebPoint&) OVERRIDE;
-    virtual void applyScrollAndScale(const WebSize&, float) OVERRIDE;
+    virtual void applyViewportProperties(const WebSize&, float, float) OVERRIDE;

[aelias_OOO_until_Jul13, 2014/09/03 19:28:42]

Please provide names for the arguments since it's no longer obvious from the
function name what it means.

I also suggest renaming to applyViewportDeltas since they're all deltas.

Also, looking forward to when the scroll delta becomes unused, how about making
it the last argument and setting a default value for it?  This will make
removing it less painful in the future.

[bokan, 2014/09/04 23:10:01]

Done
Done
I'd rather leave this for now, I'll deal with the pain in the future :)

     virtual void mouseCaptureLost() OVERRIDE;
     virtual void setFocus(bool enable) OVERRIDE;
     virtual bool setComposition(
         const WebString& text,
         const WebVector<WebCompositionUnderline>& underlines,
         int selectionStart,
         int selectionEnd) OVERRIDE;
     virtual bool confirmComposition() OVERRIDE;
     virtual bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) OVERRIDE;
     virtual bool confirmComposition(const WebString& text) OVERRIDE;
@@ skipping 583 matching lines @@
     bool m_showFPSCounter;
     bool m_showPaintRects;
     bool m_showDebugBorders;
     bool m_continuousPaintingEnabled;
     bool m_showScrollBottleneckRects;
     WebColor m_baseBackgroundColor;
     WebColor m_backgroundColorOverride;
     float m_zoomFactorOverride;
 
     bool m_userGestureObserved;
+    int m_topControlsLayoutHeight;

[aelias_OOO_until_Jul13, 2014/09/03 19:28:42]

Unused for now, please remove it.

[bokan, 2014/09/04 23:10:01]

Done.

+    float m_topControlsContentOffset;
 };
 
 // We have no ways to check if the specified WebView is an instance of
 // WebViewImpl because WebViewImpl is the only implementation of WebView.
 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
 
 } // namespace blink
 
 #endif