Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 512923002: Add support for Android aidl and support for gyp's java_in_dir (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, klundberg+watch_chromium.org, jam, yfriedman+watch_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for Android aidl and support for gyp's java_in_dir Adds the android_aidl template to support Android aidl. Adds a DEPRECATED_java_in_dir to android_library and android_apk. This will greatly ease the transition from gyp to gn. Adds BUILD.gn for third_party/eyesfree (using the two new features added). TBR=rsleevi BUG=359249 Committed: https://crrev.com/dad5f427256371787b536ccdcf08d6493bebb379 Cr-Commit-Position: refs/heads/master@{#293386}

Patch Set 1 #

Total comments: 12

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -19 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A build/android/gyp/aidl.py View 1 chunk +54 lines, -0 lines 0 comments Download
M build/android/gyp/write_build_config.py View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 3 chunks +15 lines, -3 lines 0 comments Download
M build/config/android/rules.gni View 1 10 chunks +107 lines, -11 lines 0 comments Download
A content/public/android/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M net/BUILD.gn View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
A third_party/eyesfree/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
cjhopman
cjhopman@chromium.org changed reviewers: + newt@chromium.org
6 years, 3 months ago (2014-08-27 18:36:38 UTC) #1
cjhopman
newt: *
6 years, 3 months ago (2014-08-27 18:36:38 UTC) #2
cjhopman
https://codereview.chromium.org/512923002/diff/1/build/android/gyp/write_build_config.py File build/android/gyp/write_build_config.py (right): https://codereview.chromium.org/512923002/diff/1/build/android/gyp/write_build_config.py#newcode114 build/android/gyp/write_build_config.py:114: raise Exception('Unknown deps: ' + str(unknown_deps)) Looks like some ...
6 years, 3 months ago (2014-08-27 18:37:59 UTC) #3
newt (away)
https://codereview.chromium.org/512923002/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/512923002/diff/1/build/config/android/rules.gni#newcode749 build/config/android/rules.gni:749: if (defined(invoker.datadeps)) { where are these datadeps coming from? ...
6 years, 3 months ago (2014-08-27 20:05:29 UTC) #4
cjhopman
https://codereview.chromium.org/512923002/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/512923002/diff/1/build/config/android/rules.gni#newcode749 build/config/android/rules.gni:749: if (defined(invoker.datadeps)) { On 2014/08/27 20:05:29, newt wrote: > ...
6 years, 3 months ago (2014-08-27 21:05:22 UTC) #5
newt (away)
lgtm
6 years, 3 months ago (2014-08-27 21:09:52 UTC) #6
cjhopman
cjhopman@chromium.org changed reviewers: + brettw@chromium.org
6 years, 3 months ago (2014-08-27 21:14:26 UTC) #7
cjhopman
And brettw@ for the OWNERS stamp of approval
6 years, 3 months ago (2014-08-27 21:14:26 UTC) #8
brettw
lgtm
6 years, 3 months ago (2014-09-04 21:52:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/512923002/60001
6 years, 3 months ago (2014-09-04 21:54:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/512923002/60001
6 years, 3 months ago (2014-09-04 23:14:02 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 40aaa0520c86daddc7eeee98fc5e6afd6e0ffeea
6 years, 3 months ago (2014-09-05 01:03:23 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:34:28 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dad5f427256371787b536ccdcf08d6493bebb379
Cr-Commit-Position: refs/heads/master@{#293386}

Powered by Google App Engine
This is Rietveld 408576698