Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 512703005: Don't set goma_dir in config if path_to_goma is None. (Closed)

Created:
6 years, 3 months ago by prasadv
Modified:
6 years, 3 months ago
Reviewers:
sullivan, tonyg, qyearsley
CC:
chromium-reviews, tonyg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't set goma_dir in config if path_to_goma is None. BUG=394531 NOTRY=true Committed: https://crrev.com/43d1aaaf6350f2d63ddb386d9b733a87bb54cb66 Cr-Commit-Position: refs/heads/master@{#292283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/run-bisect-perf-regression.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
prasadv
prasadv@chromium.org changed reviewers: + qyearsley@chromium.org, sullivan@chromium.org
6 years, 3 months ago (2014-08-27 23:19:28 UTC) #1
prasadv
6 years, 3 months ago (2014-08-27 23:19:28 UTC) #2
qyearsley
lgtm :-)
6 years, 3 months ago (2014-08-27 23:20:18 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 3 months ago (2014-08-27 23:20:38 UTC) #4
tonyg
tonyg@chromium.org changed reviewers: + tonyg@chromium.org
6 years, 3 months ago (2014-08-27 23:20:39 UTC) #5
tonyg
lgtm
6 years, 3 months ago (2014-08-27 23:20:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/512703005/1
6 years, 3 months ago (2014-08-27 23:21:56 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 23:23:29 UTC) #8
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 23:23:29 UTC) #9
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 3 months ago (2014-08-27 23:25:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/512703005/1
6 years, 3 months ago (2014-08-27 23:27:48 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 23:29:16 UTC) #12
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 23:29:17 UTC) #13
prasadv
The CQ bit was checked by prasadv@chromium.org
6 years, 3 months ago (2014-08-27 23:54:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prasadv@chromium.org/512703005/1
6 years, 3 months ago (2014-08-28 00:07:41 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as f47a68ba5a51b0b2d3990317f30b0d08118dd399
6 years, 3 months ago (2014-08-28 00:39:21 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:10 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/43d1aaaf6350f2d63ddb386d9b733a87bb54cb66
Cr-Commit-Position: refs/heads/master@{#292283}

Powered by Google App Engine
This is Rietveld 408576698