tools/run-bisect-perf-regression.py - Issue 512703005: Don't set goma_dir in config if path_to_goma is None.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/run-bisect-perf-regression.py

Issue 512703005: Don't set goma_dir in config if path_to_goma is None. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/run-bisect-perf-regression.py

diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py

index 9b188ec2bb1f91f14bf2313fc2df1dbcfd84cd31..cc05c0ffab3b205ac755619f9f95dd34441949dd 100755

--- a/tools/run-bisect-perf-regression.py

+++ b/tools/run-bisect-perf-regression.py

@@ -354,7 +354,8 @@ def _SetupAndRunPerformanceTest(config, path_to_file, path_to_goma):

try:

with Goma(path_to_goma) as _:

config['use_goma'] = bool(path_to_goma)

- config['goma_dir'] = os.path.abspath(path_to_goma)

+ if config['use_goma']:

+ config['goma_dir'] = os.path.abspath(path_to_goma)

_RunPerformanceTest(config, path_to_file)

return 0

except RuntimeError, e:

« no previous file with comments | « no previous file | no next file » | no next file with comments »