Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2429)

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.h

Issue 512323002: NaCl: Detect plugin crashes via EOF on Chromium IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/plugin.h
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.h b/ppapi/native_client/src/trusted/plugin/plugin.h
index a55b62d1c3be77fd47f8f358ded87696dbbe04cf..8b89a882b570e56a07dad82ff50f15820355cb8e 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.h
+++ b/ppapi/native_client/src/trusted/plugin/plugin.h
@@ -93,8 +93,7 @@ class Plugin : public pp::Instance {
bool enable_dyncode_syscalls,
bool enable_exception_handling,
bool enable_crash_throttling,
- const pp::CompletionCallback& init_done_cb,
- const pp::CompletionCallback& crash_cb);
+ const pp::CompletionCallback& init_done_cb);
// Finish hooking interfaces up, after low-level initialization is
// complete.
@@ -173,18 +172,6 @@ class Plugin : public pp::Instance {
void NexeFileDidOpen(int32_t pp_error);
void NexeFileDidOpenContinuation(int32_t pp_error);
- // Callback used when the reverse channel closes. This is an
- // asynchronous event that might turn into a JavaScript error or
- // crash event -- this is controlled by the two state variables
- // nacl_ready_state_ and nexe_error_reported_: If an error or crash
- // had already been reported, no additional crash event is
- // generated. If no error has been reported but nacl_ready_state_
- // is not DONE, then the loadend event has not been reported, and we
- // enqueue an error event followed by loadend. If nacl_ready_state_
- // is DONE, then we are in the post-loadend (we need temporal
- // predicate symbols), and we enqueue a crash event.
- void NexeDidCrash(int32_t pp_error);
-
// Callback used when a .nexe is translated from bitcode. If the translation
// is successful, the file descriptor is opened and can be passed to sel_ldr
// with the sandbox on.

Powered by Google App Engine
This is Rietveld 408576698