chrome/test/nacl/nacl_browsertest.cc - Issue 512323002: NaCl: Detect plugin crashes via EOF on Chromium IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/nacl/nacl_browsertest.cc

Issue 512323002: NaCl: Detect plugin crashes via EOF on Chromium IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/nacl/nacl_browsertest.cc

diff --git a/chrome/test/nacl/nacl_browsertest.cc b/chrome/test/nacl/nacl_browsertest.cc

index 30b6053091da9a52bd5fa1bedc5a16bcea7c1e7d..5e73e304ded3f661d87d8dfbb1e5c556c0b9a5c7 100644

--- a/chrome/test/nacl/nacl_browsertest.cc

+++ b/chrome/test/nacl/nacl_browsertest.cc

@@ -107,9 +107,6 @@ IN_PROC_BROWSER_TEST_F(NaClBrowserTestNewlib, BadNative) {

#if defined(OS_WIN)

// crbug.com/98721

# define MAYBE_Crash DISABLED_Crash

-#elif defined(OS_LINUX)

-// crbug.com/366334

Mark Seaborn 2014/08/28 20:58:39 Can you add BUG=366334 to the commit message, then

teravest 2014/09/03 15:18:22 Done.

-# define MAYBE_Crash DISABLED_Crash

#else

# define MAYBE_Crash Crash

#endif

« no previous file with comments | « no previous file | components/nacl/renderer/ppb_nacl_private_impl.cc » ('j') | ppapi/native_client/src/trusted/plugin/service_runtime.cc » ('J')