components/nacl/renderer/trusted_plugin_channel.cc - Issue 512323002: NaCl: Detect plugin crashes via EOF on Chromium IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/trusted_plugin_channel.cc

Issue 512323002: NaCl: Detect plugin crashes via EOF on Chromium IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/nacl/nacl_browsertest.cc ('K') | « components/nacl/renderer/trusted_plugin_channel.h ('k') | ppapi/api/private/ppb_nacl_private.idl » ('j') | ppapi/native_client/src/trusted/plugin/service_runtime.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/renderer/trusted_plugin_channel.cc

diff --git a/components/nacl/renderer/trusted_plugin_channel.cc b/components/nacl/renderer/trusted_plugin_channel.cc

index 0aaf6bc34c29991034a731f2bdc8852c5a16d6cb..729644cb089458632312aab5d879811dadf723a0 100644

--- a/components/nacl/renderer/trusted_plugin_channel.cc

+++ b/components/nacl/renderer/trusted_plugin_channel.cc

@@ -46,6 +46,11 @@ bool TrustedPluginChannel::OnMessageReceived(const IPC::Message& msg) {

return handled;

}

+void TrustedPluginChannel::OnChannelError() {

+ if (report_exit_status_)

+ nexe_load_manager_->NexeDidCrash();

void TrustedPluginChannel::OnReportExitStatus(int exit_status) {

if (report_exit_status_)

nexe_load_manager_->set_exit_status(exit_status);