components/nacl/renderer/ppb_nacl_private_impl.cc - Issue 512323002: NaCl: Detect plugin crashes via EOF on Chromium IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 512323002: NaCl: Detect plugin crashes via EOF on Chromium IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/nacl/nacl_browsertest.cc ('K') | « chrome/test/nacl/nacl_browsertest.cc ('k') | components/nacl/renderer/trusted_plugin_channel.h » ('j') | ppapi/native_client/src/trusted/plugin/service_runtime.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/renderer/ppb_nacl_private_impl.cc

diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc

index 44af080991f80e15921c36f8a64b94ae23d69183..c5cef0d227483c39e86eceaafe25a4919035ce31 100644

--- a/components/nacl/renderer/ppb_nacl_private_impl.cc

+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc

@@ -749,12 +749,6 @@ void ReportLoadAbort(PP_Instance instance) {

load_manager->ReportLoadAbort();

}

-void NexeDidCrash(PP_Instance instance) {

- NexeLoadManager* load_manager = NexeLoadManager::Get(instance);

- if (load_manager)

- load_manager->NexeDidCrash();

void InstanceCreated(PP_Instance instance) {

NexeLoadManager::Create(instance);

}

@@ -1684,7 +1678,6 @@ const PPB_NaCl_Private nacl_interface = {

&ReportLoadSuccess,

&ReportLoadError,

&ReportLoadAbort,

- &NexeDidCrash,

&InstanceCreated,

&InstanceDestroyed,

&NaClDebugEnabledForURL,