Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 512303002: Revert of Changes exception for gyp files to only gyp files in build/ (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Changes exception for gyp files to only gyp files in build/ (patchset #1 of https://codereview.chromium.org/512693004/) Reason for revert: I'm reverting this. http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_... should have triggered a compile. Original issue's description: > Changes exception for gyp files to only gyp files in build/ > > I changed analyzer such that if a gyp file (or an included gypi file) > changes all targets in the gyp file are marked as changed. This means > I should no longer have to special case gyp files. I'm leaving the > exception in place for any gyp files in build as any change to those > really needs to recompile the world. > > BUG=109173 > TEST=none > R=thakis@chromium.org > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b TBR=thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=109173 Committed: https://crrev.com/54b2e975d605ab6b6a6235ae8130e3bf0746a731 Cr-Commit-Position: refs/heads/master@{#292410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/buildbot/trybot_analyze_config.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
Created Revert of Changes exception for gyp files to only gyp files in build/
6 years, 3 months ago (2014-08-28 17:21:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/512303002/1
6 years, 3 months ago (2014-08-28 17:22:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as ebc95927e3a7365da5b2ae1d3d2aa588039bc82b
6 years, 3 months ago (2014-08-28 17:23:08 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54b2e975d605ab6b6a6235ae8130e3bf0746a731
Cr-Commit-Position: refs/heads/master@{#292410}

Powered by Google App Engine
This is Rietveld 408576698