Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 512253002: Combine storage_browser_export.h and storage_common_export.h (Closed)

Created:
6 years, 3 months ago by pilgrim_google
Modified:
6 years, 3 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), tzik, Lei Zhang, nhiroki, tommycli, darin-cc_chromium.org, dcheng, Greg Billock, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Combine storage_browser_export.h and storage_common_export.h BUG=338338 TBR=darin@chromium.org Committed: https://crrev.com/0363f2c67015888f402bae71239c9163ad9ae031 Cr-Commit-Position: refs/heads/master@{#292435}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -158 lines) Patch
M chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/blob_data_handle.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/blob_storage_context.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/blob_url_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/blob_url_request_job_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/file_stream_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/local_file_stream_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/view_blob_internals_job.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_quota_client.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/databases_table.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/vfs_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/async_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/copy_or_move_file_validator.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/dragged_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/external_mount_points.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_observers.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_permission_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_stream_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_context.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_file_stream_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_operation.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_operation_context.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_operation_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_operation_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_options.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_quota_client.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_quota_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_usage_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_writer_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/isolated_context.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_stream_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/mount_points.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/native_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/quota/open_file_handle.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/quota/open_file_handle_context.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/quota/quota_backend_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/quota/quota_reservation.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/quota/quota_reservation_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/quota/quota_reservation_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/timed_task_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/transient_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/quota/quota_client.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/quota/quota_database.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/quota/quota_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/quota/quota_manager_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/quota/quota_task.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/quota/quota_temporary_storage_evictor.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/quota/special_storage_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/quota/usage_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
D webkit/browser/storage_export.h View 1 chunk +0 lines, -34 lines 0 comments Download
M webkit/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/blob/blob_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/blob/scoped_file.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/common/blob/shareable_file_reference.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/database/database_connections.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/common/database/database_identifier.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/common/fileapi/directory_entry.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/fileapi/file_system_info.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/fileapi/file_system_util.h View 6 chunks +23 lines, -23 lines 0 comments Download
M webkit/common/quota/quota_status_code.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/common/storage_common_export.h View 1 chunk +8 lines, -8 lines 0 comments Download
A + webkit/common/storage_export.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webkit/storage_browser.gyp View 1 chunk +1 line, -2 lines 1 comment Download
M webkit/storage_common.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pilgrim_google
pilgrim@chromium.org changed reviewers: + jam@chromium.org, jamesr@chromium.org
6 years, 3 months ago (2014-08-28 15:28:52 UTC) #1
pilgrim_google
6 years, 3 months ago (2014-08-28 15:28:52 UTC) #2
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 3 months ago (2014-08-28 17:21:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/512253002/1
6 years, 3 months ago (2014-08-28 17:22:22 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 18:08:26 UTC) #5
jamesr
How will calls from the webkit/browser/storage DLL to the webkit/common/storage DLL work in the component ...
6 years, 3 months ago (2014-08-28 18:26:22 UTC) #6
jamesr
https://codereview.chromium.org/512253002/diff/1/webkit/storage_browser.gyp File webkit/storage_browser.gyp (left): https://codereview.chromium.org/512253002/diff/1/webkit/storage_browser.gyp#oldcode29 webkit/storage_browser.gyp:29: 'browser/storage_export.h', this target should list whatever export header it's ...
6 years, 3 months ago (2014-08-28 18:59:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as b5402ee22d7dc6abd27b132fdd3880f8ff61027e
6 years, 3 months ago (2014-08-28 19:05:14 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:01:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0363f2c67015888f402bae71239c9163ad9ae031
Cr-Commit-Position: refs/heads/master@{#292435}

Powered by Google App Engine
This is Rietveld 408576698