 Chromium Code Reviews
 Chromium Code Reviews Issue 512253002:
  Combine storage_browser_export.h and storage_common_export.h  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 512253002:
  Combine storage_browser_export.h and storage_common_export.h  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: webkit/storage_browser.gyp | 
| diff --git a/webkit/storage_browser.gyp b/webkit/storage_browser.gyp | 
| index 5083a3d56d995cd586ad056fc4027fc8233cd5d4..9ff06aa021fa61e6ed98baba135ba153a7bcc3c0 100644 | 
| --- a/webkit/storage_browser.gyp | 
| +++ b/webkit/storage_browser.gyp | 
| @@ -24,9 +24,8 @@ | 
| '<(DEPTH)/webkit/common/webkit_common.gyp:webkit_common', | 
| '<(DEPTH)/webkit/storage_common.gyp:storage_common', | 
| ], | 
| - 'defines': ['WEBKIT_STORAGE_BROWSER_IMPLEMENTATION'], | 
| + 'defines': ['STORAGE_IMPLEMENTATION'], | 
| 'sources': [ | 
| - 'browser/storage_export.h', | 
| 
jamesr
2014/08/28 18:59:56
this target should list whatever export header it'
 | 
| 'browser/blob/blob_data_handle.cc', | 
| 'browser/blob/blob_data_handle.h', | 
| 'browser/blob/blob_storage_context.cc', |