Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 512173002: Revert of Cursor to be centrally aligned instead of top aligned (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Cursor to be centrally aligned instead of top aligned (patchset #8 of https://codereview.chromium.org/447243002/) Reason for revert: This is breaking Win XP bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT%20Blink&tests=editing%2Fselection%2Fmixed-editability-10.html&testType=layout-tests Original issue's description: > Cursor to be centrally aligned instead of top aligned > > Previous code in r178276, only accounted for font height but padding, > border and box height should be also taken into account. > > BUG=400522 > R=leviw, esprehn > TEST=Various tests that need rebaseline due to code change. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181000 TBR=esprehn@chromium.org,leviw@chromium.org,habib.virji@samsung.com NOTREECHECKS=true NOTRY=true BUG=400522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -29 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/editing/caret/caret-position.html View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/platform/linux/editing/selection/mixed-editability-10-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/editing/selection/mixed-editability-10-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mlamouri (slow - plz ping)
Created Revert of Cursor to be centrally aligned instead of top aligned
6 years, 3 months ago (2014-08-28 10:15:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/512173002/1
6 years, 3 months ago (2014-08-28 10:16:25 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 10:16:31 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 3 months ago (2014-08-28 10:16:32 UTC) #4
mlamouri (slow - plz ping)
6 years, 3 months ago (2014-08-28 10:31:33 UTC) #5
Message was sent while issue was closed.
Habib has a fix so I will not land that.

Powered by Google App Engine
This is Rietveld 408576698