DevTools: Show preview in console of ES6 Map, Set, WeakMap and WeakSet entries.

DevTools: Show preview in console of ES6 Map, Set, WeakMap and WeakSet entries.

BUG=376196
R=yurys, vsevik

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181972

[aandrey, 2014-09-01 09:11:03]

ping?

[vsevik, 2014-09-01 14:05:45]

vsevik@chromium.org changed reviewers:
+ pfeldman@chromium.org

[aandrey, 2014-09-11 06:46:07]

@yurys, could you please take a look?

[yurys, 2014-09-14 12:42:03]

https://codereview.chromium.org/512003003/diff/60001/Source/core/inspector/In...
File Source/core/inspector/InjectedScriptSource.js (right):

https://codereview.chromium.org/512003003/diff/60001/Source/core/inspector/In...
Source/core/inspector/InjectedScriptSource.js:1337: push(preview.entries,
previewEntry);
Is it to avoid calling overwritten Array.prototype.push?

https://codereview.chromium.org/512003003/diff/60001/Source/devtools/front_en...
File Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/512003003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/sdk/RemoteObject.js:900: name = "\"" +
name.replace(/\n/g, "\u21B5") + "\"";
Shouldn't we always show the name quoted? It may be confusing when you have only
some of the keys in quotes. WDYT?

https://codereview.chromium.org/512003003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/sdk/RemoteObject.js:906: this._cachedDescription = "{"
+ formatValue(children[0].value) + " => " + formatValue(children[1].value) +
"}";
Should this go under case "map" below?

[aandrey, 2014-09-15 06:51:58]

https://codereview.chromium.org/512003003/diff/60001/Source/core/inspector/In...
File Source/core/inspector/InjectedScriptSource.js (right):

https://codereview.chromium.org/512003003/diff/60001/Source/core/inspector/In...
Source/core/inspector/InjectedScriptSource.js:1337: push(preview.entries,
previewEntry);
On 2014/09/14 12:42:03, yurys wrote:
> Is it to avoid calling overwritten Array.prototype.push?

Yep. We also have a presubmit check to catch this.

https://codereview.chromium.org/512003003/diff/60001/Source/devtools/front_en...
File Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/512003003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/sdk/RemoteObject.js:900: name = "\"" +
name.replace(/\n/g, "\u21B5") + "\"";
On 2014/09/14 12:42:03, yurys wrote:
> Shouldn't we always show the name quoted? It may be confusing when you have
only
> some of the keys in quotes. WDYT?

There is quite a few places where we do this. The idea was that we should use ""
only when it's really needed (see the regex pattern).

https://codereview.chromium.org/512003003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/sdk/RemoteObject.js:906: this._cachedDescription = "{"
+ formatValue(children[0].value) + " => " + formatValue(children[1].value) +
"}";
On 2014/09/14 12:42:03, yurys wrote:
> Should this go under case "map" below?

This is a map entry, simulated by a local RemoteObject (i.e. this.subtype is
undefined).

[aandrey, 2014-09-15 07:57:01]

Introduced WebInspector.MapEntryLocalJSONObject
PTAL

[yurys, 2014-09-15 08:25:50]

lgtm

[aandrey, 2014-09-15 08:29:34]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-09-15 08:29:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/512003003/100001

[commit-bot: I haz the power, 2014-09-15 09:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-15 09:38:17]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

[aandrey, 2014-09-15 10:25:08]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-09-15 10:26:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/512003003/120001

[commit-bot: I haz the power, 2014-09-15 12:02:17]

Committed patchset #7 (id:120001) as 181972