Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 512003003: DevTools: Show preview in console of ES6 Map, Set, WeakMap and WeakSet entries. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixed dbg tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/ObjectPropertiesSection.js
diff --git a/Source/devtools/front_end/components/ObjectPropertiesSection.js b/Source/devtools/front_end/components/ObjectPropertiesSection.js
index 731edaed552a5f097d279ebb10ce69203e6a6ae5..c28a0f25d4384ca4985dac3ab9388948bfb62edd 100644
--- a/Source/devtools/front_end/components/ObjectPropertiesSection.js
+++ b/Source/devtools/front_end/components/ObjectPropertiesSection.js
@@ -578,7 +578,7 @@ WebInspector.ObjectPropertyTreeElement.populateWithProperties = function(treeEle
}
/**
- * @param {!WebInspector.RemoteObject} object
+ * @param {?WebInspector.RemoteObject} object
* @param {!Array.<string>} propertyPath
* @param {function(?WebInspector.RemoteObject, boolean=)} callback
* @return {!Element}
@@ -586,8 +586,11 @@ WebInspector.ObjectPropertyTreeElement.populateWithProperties = function(treeEle
WebInspector.ObjectPropertyTreeElement.createRemoteObjectAccessorPropertySpan = function(object, propertyPath, callback)
{
var rootElement = document.createElement("span");
- var element = rootElement.createChild("span", "properties-calculate-value-button");
+ var element = rootElement.createChild("span");
element.textContent = WebInspector.UIString("(...)");
+ if (!object)
+ return rootElement;
+ element.classList.add("properties-calculate-value-button");
element.title = WebInspector.UIString("Invoke property getter");
element.addEventListener("click", onInvokeGetterClick, false);
@@ -721,10 +724,10 @@ WebInspector.CollectionEntriesMainTreeElement.prototype = {
for (var i = 0; i < entries.length; ++i) {
var entry = entries[i];
if (entry.key) {
- entriesLocalObject.push({
+ entriesLocalObject.push(new WebInspector.MapEntryLocalJSONObject({
key: runtimeModel.createRemoteObject(entry.key),
value: runtimeModel.createRemoteObject(entry.value)
- });
+ }));
} else {
entriesLocalObject.push(runtimeModel.createRemoteObject(entry.value));
}
« no previous file with comments | « Source/core/inspector/InjectedScriptSource.js ('k') | Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698