Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 511923004: Simplify IOSurface CoreAnimation code: Part 1 (Closed)

Created:
6 years, 3 months ago by ccameron
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Simplify IOSurface CoreAnimation code: Part 1 This is now only used in the context of the browser compositor, so move the code there. Move the software layer code over to compositor as well. Rename structures to de-empahsize 'compositing' (everything is running through the compositor now). BUG=314190 TBR=kbr@chromium.org Committed: https://crrev.com/9f9a14caa0da18e8cfe84a619c0f66f4b2901710 Cr-Commit-Position: refs/heads/master@{#292482}

Patch Set 1 #

Patch Set 2 : Use accessors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -716 lines) Patch
M content/browser/compositor/browser_compositor_view_private_mac.h View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/compositor/browser_compositor_view_private_mac.mm View 1 11 chunks +27 lines, -38 lines 0 comments Download
A + content/browser/compositor/io_surface_layer_mac.h View 1 3 chunks +37 lines, -28 lines 0 comments Download
A + content/browser/compositor/io_surface_layer_mac.mm View 1 12 chunks +56 lines, -32 lines 0 comments Download
A + content/browser/compositor/software_layer_mac.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/compositor/software_layer_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/renderer_host/compositing_iosurface_layer_mac.h View 1 chunk +0 lines, -152 lines 0 comments Download
D content/browser/renderer_host/compositing_iosurface_layer_mac.mm View 1 chunk +0 lines, -300 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 3 chunks +1 line, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 3 chunks +40 lines, -56 lines 0 comments Download
D content/browser/renderer_host/software_layer_mac.h View 1 chunk +0 lines, -22 lines 0 comments Download
D content/browser/renderer_host/software_layer_mac.mm View 1 chunk +0 lines, -68 lines 0 comments Download
M content/content_browser.gypi View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
ccameron
This is the non-functional half of https://codereview.chromium.org/490393002/ I've separated this from the other bit because ...
6 years, 3 months ago (2014-08-28 17:25:57 UTC) #1
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 3 months ago (2014-08-28 17:26:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/511923004/1
6 years, 3 months ago (2014-08-28 17:27:24 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 17:27:24 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-08-28 17:27:25 UTC) #5
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 3 months ago (2014-08-28 17:35:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/511923004/1
6 years, 3 months ago (2014-08-28 17:36:45 UTC) #7
ccameron
The CQ bit was unchecked by ccameron@chromium.org
6 years, 3 months ago (2014-08-28 18:11:17 UTC) #8
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 3 months ago (2014-08-28 19:15:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/511923004/20001
6 years, 3 months ago (2014-08-28 19:16:57 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-28 20:29:49 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:56:10 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/8181)
6 years, 3 months ago (2014-08-28 20:56:11 UTC) #13
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 3 months ago (2014-08-28 21:26:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/511923004/20001
6 years, 3 months ago (2014-08-28 21:27:34 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as da9d2286b1176ce5ff20fe41580ba32a2f973076
6 years, 3 months ago (2014-08-28 22:42:35 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:02:56 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f9a14caa0da18e8cfe84a619c0f66f4b2901710
Cr-Commit-Position: refs/heads/master@{#292482}

Powered by Google App Engine
This is Rietveld 408576698