Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 511903002: Clearing Tabs and Observer list when TabModelBase is destroyed. (Closed)

Created:
6 years, 3 months ago by wajahat
Modified:
6 years, 3 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clearing Tabs and Observer list when TabModelBase is destroyed. When TabModelBase is destroyed, Tabs and Observers List should be cleared to free any holding tabs and observers respectively. BUG=None. Committed: https://crrev.com/eacf155f2d41b79a64c9b4eca997e62ebc77b8cb Cr-Commit-Position: refs/heads/master@{#292326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
wajahat
wajahat.s@samsung.com changed reviewers: + bauerb@chromium.org, yfriedman@chromium.org
6 years, 3 months ago (2014-08-27 15:03:13 UTC) #1
wajahat
Please review.
6 years, 3 months ago (2014-08-27 15:03:13 UTC) #2
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-08-27 17:03:13 UTC) #3
Yaron
lgtm
6 years, 3 months ago (2014-08-27 18:14:16 UTC) #4
wajahat
The CQ bit was checked by wajahat.s@samsung.com
6 years, 3 months ago (2014-08-28 04:21:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wajahat.s@samsung.com/511903002/1
6 years, 3 months ago (2014-08-28 04:22:27 UTC) #6
wajahat
wajahat.s@samsung.com changed reviewers: + jitendra.ks@samsung.com - bauerb@chromium.org, yfriedman@chromium.org
6 years, 3 months ago (2014-08-28 04:23:35 UTC) #7
wajahat
6 years, 3 months ago (2014-08-28 04:23:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 91103f8e85da67f27833d1033d933cf4bc105a41
6 years, 3 months ago (2014-08-28 05:30:21 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:57:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eacf155f2d41b79a64c9b4eca997e62ebc77b8cb
Cr-Commit-Position: refs/heads/master@{#292326}

Powered by Google App Engine
This is Rietveld 408576698