chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java - Issue 511903002: Clearing Tabs and Observer list when TabModelBase is destroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java

Issue 511903002: Clearing Tabs and Observer list when TabModelBase is destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java

index 50dca1d9cd185fe31c01d853fa678077463bb8b5..db60b93a1013ae26419b3764d0a8b4bcb93041c6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java

@@ -85,6 +85,9 @@ public abstract class TabModelBase implements TabModel {

nativeDestroy(mNativeTabModelImpl);

mNativeTabModelImpl = 0;

}

+ mTabs.clear();

+ mObservers.clear();

}

@Override

« no previous file with comments | « no previous file | no next file » | no next file with comments »