Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issue 511893002: Guarantees ServiceWorkerCacheStorage callbacks are called. (Closed)

Created:
6 years, 3 months ago by jkarlin
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@guarantee_init
Project:
chromium
Visibility:
Public.

Description

Guarantees ServiceWorkerCacheStorage callbacks are called by making the callback functions static and passing a WeakPtr to the ServiceWorkerCacheStorage where necessary. Part of the following CL chain to guarantee callbacks are called throughout ServiceWorkerCacheStorage: 1. Guarantee CacheLoader callbacks: https://codereview.chromium.org/504233003/ 2. Guarantee LazyInit callbacks: https://codereview.chromium.org/512743002/ * 3. Guarantee Create/Delete callbacks: https://codereview.chromium.org/511893002/ 4. Reorganize the methods: https://codereview.chromium.org/510813002/ BUG=392621

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -31 lines) Patch
M content/browser/service_worker/service_worker_cache_storage.h View 1 chunk +20 lines, -16 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage.cc View 6 chunks +21 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jkarlin
Patchset #3 (id:40001) has been deleted
6 years, 3 months ago (2014-08-27 14:24:25 UTC) #1
jkarlin
Patchset #2 (id:20001) has been deleted
6 years, 3 months ago (2014-08-27 14:24:31 UTC) #2
jkarlin
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-27 14:24:38 UTC) #3
jkarlin
jkarlin@chromium.org changed reviewers: + michaeln@chromium.org
6 years, 3 months ago (2014-08-27 14:47:47 UTC) #4
jkarlin
michaeln: Please review all. Thanks!
6 years, 3 months ago (2014-08-27 14:47:47 UTC) #5
jkarlin
jkarlin@chromium.org changed reviewers: + horo@chromium.org
6 years, 3 months ago (2014-08-27 16:12:17 UTC) #6
jkarlin
On 2014/08/27 16:12:17, jkarlin wrote: > mailto:jkarlin@chromium.org changed reviewers: > + mailto:horo@chromium.org horo + michaeln: ...
6 years, 3 months ago (2014-08-27 16:15:23 UTC) #7
jkarlin
jkarlin@chromium.org changed reviewers: - horo@chromium.org, michaeln@chromium.org
6 years, 3 months ago (2014-08-28 11:03:28 UTC) #8
jkarlin
6 years, 3 months ago (2014-08-28 11:05:24 UTC) #9
On 2014/08/28 11:03:28, jkarlin wrote:
> mailto:jkarlin@chromium.org changed reviewers:
> - mailto:horo@chromium.org, mailto:michaeln@chromium.org

Removed reviewers as this patch isn't required and adds complexity.

Powered by Google App Engine
This is Rietveld 408576698