Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: content/browser/service_worker/service_worker_cache_storage.h

Issue 511893002: Guarantees ServiceWorkerCacheStorage callbacks are called. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guarantee_init
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_cache_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_cache_storage.h
diff --git a/content/browser/service_worker/service_worker_cache_storage.h b/content/browser/service_worker/service_worker_cache_storage.h
index 5618d619a44a651dba8894afd85454515a8ad694..ca2adc3c060bb99ead2daf729850a993dc58e25e 100644
--- a/content/browser/service_worker/service_worker_cache_storage.h
+++ b/content/browser/service_worker/service_worker_cache_storage.h
@@ -116,29 +116,33 @@ class CONTENT_EXPORT ServiceWorkerCacheStorage {
scoped_ptr<ServiceWorkerCache> cache);
static void LazyInitDone(base::WeakPtr<ServiceWorkerCacheStorage> storage);
- void DidCreateBackend(base::WeakPtr<ServiceWorkerCache> cache,
- CacheID cache_id,
- const CacheAndErrorCallback& callback,
- ServiceWorkerCache::ErrorType error);
+ static void DidCreateBackend(base::WeakPtr<ServiceWorkerCache> cache,
+ CacheID cache_id,
+ const CacheAndErrorCallback& callback,
+ ServiceWorkerCache::ErrorType error);
CacheContext* AddCacheToMaps(const std::string& cache_name,
scoped_ptr<ServiceWorkerCache> cache);
// The CreateCache callbacks are below.
- void CreateCacheDidCreateCache(const std::string& cache_name,
- const CacheAndErrorCallback& callback,
- scoped_ptr<ServiceWorkerCache> cache);
- void CreateCacheDidWriteIndex(const CacheAndErrorCallback& callback,
- base::WeakPtr<ServiceWorkerCache> cache,
- CacheID id,
- bool success);
+ static void CreateCacheDidCreateCache(
+ const std::string& cache_name,
+ const CacheAndErrorCallback& callback,
+ base::WeakPtr<ServiceWorkerCacheStorage> storage,
+ scoped_ptr<ServiceWorkerCache> cache);
+ static void CreateCacheDidWriteIndex(const CacheAndErrorCallback& callback,
+ base::WeakPtr<ServiceWorkerCache> cache,
+ CacheID id,
+ bool success);
// The DeleteCache callbacks are below.
- void DeleteCacheDidWriteIndex(const std::string& cache_name,
- const BoolAndErrorCallback& callback,
- bool success);
- void DeleteCacheDidCleanUp(const BoolAndErrorCallback& callback,
- bool success);
+ static void DeleteCacheDidWriteIndex(
+ const std::string& cache_name,
+ const BoolAndErrorCallback& callback,
+ base::WeakPtr<ServiceWorkerCacheStorage> storage,
+ bool success);
+ static void DeleteCacheDidCleanUp(const BoolAndErrorCallback& callback,
+ bool success);
// Whether or not we've loaded the list of cache names into memory.
bool initialized_;
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_cache_storage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698