Issue 511753002: Fix NULL dereference in SearchProviderTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 511753002: Fix NULL dereference in SearchProviderTest (Closed)

Created:
6 years, 3 months ago by hashimoto

Modified:
6 years, 3 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, James Su, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix NULL dereference in SearchProviderTest BUG=407750 TEST=unit_tests Committed: https://crrev.com/d74287d2cfa09cbb7df89e79c6da9279028fb512 Cr-Commit-Position: refs/heads/master@{#292116}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider_unittest.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/valgrind/gtest_exclude/unit_tests.gtest.txt	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 7 (0 generated)

hashimoto

hashimoto@chromium.org changed reviewers: + pkasting@chromium.org

6 years, 3 months ago (2014-08-27 04:44:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/511753002/1

6 years, 3 months ago (2014-08-27 07:04:26 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (1) as 05ca51b0fd92e087d8488efd0971c7071d5f1292

6 years, 3 months ago (2014-08-27 07:40:35 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:50:25 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d74287d2cfa09cbb7df89e79c6da9279028fb512
Cr-Commit-Position: refs/heads/master@{#292116}