Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: chrome/browser/autocomplete/search_provider_unittest.cc

Issue 511753002: Fix NULL dereference in SearchProviderTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc
index 9432ac87d791841d2dee0020967ddbf4a6487c8a..5742649d078f2c4be4444eb4e168d34d9561828b 100644
--- a/chrome/browser/autocomplete/search_provider_unittest.cc
+++ b/chrome/browser/autocomplete/search_provider_unittest.cc
@@ -292,6 +292,9 @@ void SearchProviderTest::SetUp() {
// requests to ensure the InMemoryDatabase is the state we expect it.
profile_.BlockUntilHistoryProcessesPendingRequests();
+ AutocompleteClassifierFactory::GetInstance()->SetTestingFactoryAndUse(
+ &profile_, &AutocompleteClassifierFactory::BuildInstanceFor);
+
provider_ = new SearchProviderForTest(this, turl_model, &profile_);
provider_->kMinimumTimeBetweenSuggestQueriesMs = 0;
}
@@ -661,8 +664,6 @@ TEST_F(SearchProviderTest, SendNonPrivateDataToSuggest) {
}
TEST_F(SearchProviderTest, DontAutocompleteURLLikeTerms) {
- AutocompleteClassifierFactory::GetInstance()->SetTestingFactoryAndUse(
- &profile_, &AutocompleteClassifierFactory::BuildInstanceFor);
GURL url = AddSearchToHistory(default_t_url_,
ASCIIToUTF16("docs.google.com"), 1);

Powered by Google App Engine
This is Rietveld 408576698