chrome/browser/file_select_helper.cc - Issue 511473002: Remove implicit conversions from scoped_refptr to T* in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/file_select_helper.cc

Issue 511473002: Remove implicit conversions from scoped_refptr to T* in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move download out Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/file_select_helper.cc

diff --git a/chrome/browser/file_select_helper.cc b/chrome/browser/file_select_helper.cc

index 9c0fdbb423e15cec486437f5efe574bce9ad9a61..fa0004ccb2edabad900f27e883d9b98fbe83c6a6 100644

--- a/chrome/browser/file_select_helper.cc

+++ b/chrome/browser/file_select_helper.cc

@@ -365,7 +365,7 @@ void FileSelectHelper::RunFileChooserOnUIThread(

select_file_dialog_ = ui::SelectFileDialog::Create(

this, new ChromeSelectFilePolicy(web_contents_));

- if (!select_file_dialog_)

+ if (!select_file_dialog_.get())

return;

dialog_mode_ = params.mode;

« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »