Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: chrome/browser/file_select_helper.cc

Issue 511473002: Remove implicit conversions from scoped_refptr to T* in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move download out Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/file_select_helper.h" 5 #include "chrome/browser/file_select_helper.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 const FileChooserParams& params) { 358 const FileChooserParams& params) {
359 if (!render_view_host_ || !web_contents_) { 359 if (!render_view_host_ || !web_contents_) {
360 // If the renderer was destroyed before we started, just cancel the 360 // If the renderer was destroyed before we started, just cancel the
361 // operation. 361 // operation.
362 RunFileChooserEnd(); 362 RunFileChooserEnd();
363 return; 363 return;
364 } 364 }
365 365
366 select_file_dialog_ = ui::SelectFileDialog::Create( 366 select_file_dialog_ = ui::SelectFileDialog::Create(
367 this, new ChromeSelectFilePolicy(web_contents_)); 367 this, new ChromeSelectFilePolicy(web_contents_));
368 if (!select_file_dialog_) 368 if (!select_file_dialog_.get())
369 return; 369 return;
370 370
371 dialog_mode_ = params.mode; 371 dialog_mode_ = params.mode;
372 switch (params.mode) { 372 switch (params.mode) {
373 case FileChooserParams::Open: 373 case FileChooserParams::Open:
374 dialog_type_ = ui::SelectFileDialog::SELECT_OPEN_FILE; 374 dialog_type_ = ui::SelectFileDialog::SELECT_OPEN_FILE;
375 break; 375 break;
376 case FileChooserParams::OpenMultiple: 376 case FileChooserParams::OpenMultiple:
377 dialog_type_ = ui::SelectFileDialog::SELECT_OPEN_MULTI_FILE; 377 dialog_type_ = ui::SelectFileDialog::SELECT_OPEN_MULTI_FILE;
378 break; 378 break;
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 // of an extension or a "/" in the case of a MIME type). 478 // of an extension or a "/" in the case of a MIME type).
479 std::string unused; 479 std::string unused;
480 if (accept_type.length() <= 1 || 480 if (accept_type.length() <= 1 ||
481 base::StringToLowerASCII(accept_type) != accept_type || 481 base::StringToLowerASCII(accept_type) != accept_type ||
482 base::TrimWhitespaceASCII(accept_type, base::TRIM_ALL, &unused) != 482 base::TrimWhitespaceASCII(accept_type, base::TRIM_ALL, &unused) !=
483 base::TRIM_NONE) { 483 base::TRIM_NONE) {
484 return false; 484 return false;
485 } 485 }
486 return true; 486 return true;
487 } 487 }
OLDNEW
« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698