No longer register app window placement preference keys on the fly.

chrome/browser/ui/browser_window_state.h

Index: chrome/browser/ui/browser_window_state.h
diff --git a/chrome/browser/ui/browser_window_state.h b/chrome/browser/ui/browser_window_state.h
index ec5e7ff1ea51f3f0a07e0687170d06b33a7eac6d..064dd8033e53e38aa17257fee5a0c16d3a9468f5 100644
--- a/chrome/browser/ui/browser_window_state.h
+++ b/chrome/browser/ui/browser_window_state.h
@@ -7,17 +7,30 @@
 
 #include <string>
 
+#include "base/memory/scoped_ptr.h"
+#include "base/prefs/scoped_user_pref_update.h"
 #include "ui/base/ui_base_types.h"
 
 class Browser;
 
+namespace base {
+class DictionaryValue;
+}
+
 namespace gfx {
 class Rect;
 }
 
+class PrefService;
+
 namespace chrome {
 
-std::string GetWindowPlacementKey(const Browser* browser);
+std::string GetWindowName(const Browser* browser);
+scoped_ptr<DictionaryPrefUpdate> GetWindowPlacementDictionaryReadWrite(
+    const std::string& window_name,
+    PrefService* prefs);
+const base::DictionaryValue* GetWindowPlacementDictionaryReadOnly(
+    const Browser* browser);

[Peter Kasting, 2014/09/11 20:31:50]

It seems a bit curious that these methods would take such seemingly-unrelated
arguments.  Is making them match impossible?

Consider adding comments on these regardless (what is a window placement
dictionary?  What do the args mean?  When can these fail?)

[dgrogan, 2014/09/12 01:23:03]

I'd wanted to avoid the FindPreference call in the implementation of
"ReadWrite". But since it's in "ReadWrite" it might as well be in "ReadOnly" as
well. Changed.
Done.

 
 bool ShouldSaveWindowPlacement(const Browser* browser);