No longer register app window placement preference keys on the fly.

chrome/browser/ui/browser_window_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_STATE_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_STATE_H_
 
 #include <string>
 
+#include "base/memory/scoped_ptr.h"
+#include "base/prefs/scoped_user_pref_update.h"
 #include "ui/base/ui_base_types.h"
 
 class Browser;
 
+namespace base {
+class DictionaryValue;
+}
+
 namespace gfx {
 class Rect;
 }
 
+class PrefService;
+
 namespace chrome {
 
-std::string GetWindowPlacementKey(const Browser* browser);
+std::string GetWindowName(const Browser* browser);
+scoped_ptr<DictionaryPrefUpdate> GetWindowPlacementDictionaryReadWrite(
+    const std::string& window_name,
+    PrefService* prefs);
+const base::DictionaryValue* GetWindowPlacementDictionaryReadOnly(
+    const Browser* browser);

[Peter Kasting, 2014/09/11 20:31:50]

It seems a bit curious that these methods would take such seemingly-unrelated
arguments.  Is making them match impossible?

Consider adding comments on these regardless (what is a window placement
dictionary?  What do the args mean?  When can these fail?)

[dgrogan, 2014/09/12 01:23:03]

I'd wanted to avoid the FindPreference call in the implementation of
"ReadWrite". But since it's in "ReadWrite" it might as well be in "ReadOnly" as
well. Changed.
Done.

 
 bool ShouldSaveWindowPlacement(const Browser* browser);
 
 void SaveWindowPlacement(const Browser* browser,
                          const gfx::Rect& bounds,
                          ui::WindowShowState show_state);
 
 // Return the |bounds| for the browser window to be used upon creation.
 // The |show_state| variable will receive the desired initial show state for
 // the window.
 void GetSavedWindowBoundsAndShowState(const Browser* browser,
                                       gfx::Rect* bounds,
                                       ui::WindowShowState* show_state);
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_STATE_H_