Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: base/prefs/pref_service.h

Issue 511393003: No longer register app window placement preference keys on the fly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/prefs/pref_service.cc » ('j') | chrome/browser/devtools/devtools_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/pref_service.h
diff --git a/base/prefs/pref_service.h b/base/prefs/pref_service.h
index 186433c1b62907c16eb3360ca8d567ca2b1a07a6..56231c364e40dbf1a8a8776cff31eadc527d6a8d 100644
--- a/base/prefs/pref_service.h
+++ b/base/prefs/pref_service.h
@@ -30,12 +30,17 @@ class PrefNotifierImpl;
class PrefObserver;
class PrefRegistry;
class PrefValueStore;
+class PrefService;
class PrefStore;
namespace base {
class FilePath;
}
+namespace chrome {
+void MigrateBrowserUIUserPrefs(PrefService* prefs);
+}
+
namespace subtle {
class PrefMemberBase;
class ScopedUserPrefUpdateBase;
@@ -307,6 +312,9 @@ class BASE_PREFS_EXPORT PrefService : public base::NonThreadSafe {
friend class PrefChangeRegistrar;
friend class subtle::PrefMemberBase;
+ // For access to GetBrowserDictionary below.
+ friend void chrome::MigrateBrowserUIUserPrefs(PrefService* prefs);
+
// These are protected so they can only be accessed by the friend
// classes listed above.
//
@@ -348,6 +356,11 @@ class BASE_PREFS_EXPORT PrefService : public base::NonThreadSafe {
// actually get the value.).
const base::Value* GetPreferenceValue(const std::string& path) const;
+ // This is only to be used to migrate unregistered prefs to become registered.
+ // TODO(dgrogan): Can be removed when m39 goes to stable. See
+ // http://crbug.com/167256.
+ scoped_ptr<base::DictionaryValue> GetBrowserDictionary() const;
+
// Local cache of registered Preference objects. The pref_registry_
// is authoritative with respect to what the types and default values
// of registered preferences are.
« no previous file with comments | « no previous file | base/prefs/pref_service.cc » ('j') | chrome/browser/devtools/devtools_window.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698