No longer register app window placement preference keys on the fly.

base/prefs/pref_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This provides a way to access the application's current preferences.
 
 // Chromium settings and storage represent user-selected preferences and
 // information and MUST not be extracted, overwritten or modified except
 // through Chromium defined APIs.
 
@@ skipping 12 matching lines @@
 #include "base/prefs/base_prefs_export.h"
 #include "base/prefs/persistent_pref_store.h"
 #include "base/threading/non_thread_safe.h"
 #include "base/values.h"
 
 class PrefNotifier;
 class PrefNotifierImpl;
 class PrefObserver;
 class PrefRegistry;
 class PrefValueStore;
+class PrefService;
 class PrefStore;
 
 namespace base {
 class FilePath;
 }
 
+namespace chrome {
+void MigrateBrowserUIUserPrefs(PrefService* prefs);
+}
+
 namespace subtle {
 class PrefMemberBase;
 class ScopedUserPrefUpdateBase;
 }
 
 // Base class for PrefServices. You can use the base class to read and
 // interact with preferences, but not to register new preferences; for
 // that see e.g. PrefRegistrySimple.
 //
 // Settings and storage accessed through this class represent
@@ skipping 251 matching lines @@
 
   // Registration of pref change observers must be done using the
   // PrefChangeRegistrar, which is declared as a friend here to grant it
   // access to the otherwise protected members Add/RemovePrefObserver.
   // PrefMember registers for preferences changes notification directly to
   // avoid the storage overhead of the registrar, so its base class must be
   // declared as a friend, too.
   friend class PrefChangeRegistrar;
   friend class subtle::PrefMemberBase;
 
+  // For access to GetBrowserDictionary below.
+  friend void chrome::MigrateBrowserUIUserPrefs(PrefService* prefs);
+
   // These are protected so they can only be accessed by the friend
   // classes listed above.
   //
   // If the pref at the given path changes, we call the observer's
   // OnPreferenceChanged method. Note that observers should not call
   // these methods directly but rather use a PrefChangeRegistrar to
   // make sure the observer gets cleaned up properly.
   //
   // Virtual for testing.
   virtual void AddPrefObserver(const char* path, PrefObserver* obs);
@@ skipping 21 matching lines @@
   base::Value* GetMutableUserPref(const char* path,
                                   base::Value::Type type);
 
   // GetPreferenceValue is the equivalent of FindPreference(path)->GetValue(),
   // it has been added for performance. If is faster because it does
   // not need to find or create a Preference object to get the
   // value (GetValue() calls back though the preference service to
   // actually get the value.).
   const base::Value* GetPreferenceValue(const std::string& path) const;
 
+  // This is only to be used to migrate unregistered prefs to become registered.
+  // TODO(dgrogan): Can be removed when m39 goes to stable. See
+  // http://crbug.com/167256.
+  scoped_ptr<base::DictionaryValue> GetBrowserDictionary() const;
+
   // Local cache of registered Preference objects. The pref_registry_
   // is authoritative with respect to what the types and default values
   // of registered preferences are.
   mutable PreferenceMap prefs_map_;
 
   DISALLOW_COPY_AND_ASSIGN(PrefService);
 };
 
 #endif  // BASE_PREFS_PREF_SERVICE_H_