No longer register app window placement preference keys on the fly.

base/prefs/pref_service.cc

Index: base/prefs/pref_service.cc
diff --git a/base/prefs/pref_service.cc b/base/prefs/pref_service.cc
index 65605c5f8e6d346f1d10f82b3a1dc76b08e989a9..b0a70e04a2a64cf4a42fba294aa37e74051f1c1e 100644
--- a/base/prefs/pref_service.cc
+++ b/base/prefs/pref_service.cc
@@ -554,3 +554,15 @@ const base::Value* PrefService::GetPreferenceValue(
 
   return NULL;
 }
+
+scoped_ptr<base::DictionaryValue> PrefService::GetBrowserDictionary() const {
+  const base::Value* browser_value = NULL;

[dgrogan, 2014/09/04 00:50:51]

The other accessor methods use pref_registry to get values. But the values that
I'm trying to migrate don't have a registered key.

+  if (!user_pref_store_->GetValue("browser", &browser_value))
+    return scoped_ptr<base::DictionaryValue>();
+  const base::DictionaryValue* browser_dict = NULL;
+  if (!browser_value->GetAsDictionary(&browser_dict)) {
+    NOTREACHED();

[Bernhard Bauer, 2014/09/04 11:06:02]

Using NOTREACHED() to handle the result of a check implies that the check could
fail, which contradicts the NOTREACHED(). Use a DCHECK instead to check the
result. See also
http://dev.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-.

(I know there are other places in this file that use NOTREACHED(), but they are
old code that should be fixed).

[dgrogan, 2014/09/04 20:26:32]

Removed the NOTREACHED since it is possible that someone modified their
"browser" entry to be a non-dictionary.

+    return scoped_ptr<base::DictionaryValue>();
+  }
+  return make_scoped_ptr(browser_dict->DeepCopy());
+}