No longer register app window placement preference keys on the fly.

base/prefs/pref_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/prefs/pref_service.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 536 matching lines @@
       DCHECK(found_value->IsType(default_type));
       return found_value;
     } else {
       // Every registered preference has at least a default value.
       NOTREACHED() << "no valid value found for registered pref " << path;
     }
   }
 
   return NULL;
 }
+
+scoped_ptr<base::DictionaryValue> PrefService::GetBrowserDictionary() const {
+  const base::Value* browser_value = NULL;

[dgrogan, 2014/09/04 00:50:51]

The other accessor methods use pref_registry to get values. But the values that
I'm trying to migrate don't have a registered key.

+  if (!user_pref_store_->GetValue("browser", &browser_value))
+    return scoped_ptr<base::DictionaryValue>();
+  const base::DictionaryValue* browser_dict = NULL;
+  if (!browser_value->GetAsDictionary(&browser_dict)) {
+    NOTREACHED();

[Bernhard Bauer, 2014/09/04 11:06:02]

Using NOTREACHED() to handle the result of a check implies that the check could
fail, which contradicts the NOTREACHED(). Use a DCHECK instead to check the
result. See also
http://dev.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-.

(I know there are other places in this file that use NOTREACHED(), but they are
old code that should be fixed).

[dgrogan, 2014/09/04 20:26:32]

Removed the NOTREACHED since it is possible that someone modified their
"browser" entry to be a non-dictionary.

+    return scoped_ptr<base::DictionaryValue>();
+  }
+  return make_scoped_ptr(browser_dict->DeepCopy());
+}