Use failure.tree field provided by the builder_alerts generator

Use failure.tree field provided by the builder_alerts generator

Depends on https://codereview.chromium.org/508873005/.

BUG=406969
R=ojan@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181652

[ojan, 2014-08-28 22:36:58]

The code change looks good. Do we not have any tests for this code? It'd be nice
if you could add a basic test if we don't.

Also, this code has moved into model/ct-failures.html.

Thanks for fixing this.

[Sergiy Byelozyorov, 2014-08-29 12:44:13]

On 2014/08/28 22:36:58, ojan-only-code-yellow-reviews wrote:
> The code change looks good. Do we not have any tests for this code? It'd be
nice
> if you could add a basic test if we don't.
> 
> Also, this code has moved into model/ct-failures.html.
> 
> Thanks for fixing this.

I've added tests by analogy, but not sure how to run them. What is this
framework? Can you please point me to the right URL describing how to use it for
local testing (both unit-testing and integration-testing)?

[Jeffrey Yasskin, 2014-08-30 02:57:03]

On 2014/08/29 12:44:13, Sergiy Byelozyorov wrote:
> On 2014/08/28 22:36:58, ojan-only-code-yellow-reviews wrote:
> > The code change looks good. Do we not have any tests for this code? It'd be
> nice
> > if you could add a basic test if we don't.
> > 
> > Also, this code has moved into model/ct-failures.html.
> > 
> > Thanks for fixing this.
> 
> I've added tests by analogy, but not sure how to run them. What is this
> framework? Can you please point me to the right URL describing how to use it
for
> local testing (both unit-testing and integration-testing)?

See
https://code.google.com/p/chromium/codesearch/#chromium/src/third_party/WebKi....
It's karma/mocha/chai, and `make test` will kick it off. Install npm&bower and
run `make update` first to install the dependencies.

[ojan, 2014-09-01 23:42:26]

lgtm assuming you get the test to run and pass locally. Also, of course you need
to wait until the dependent patch has landed and builder_alerts does a cycle so
that it gets the new tree names in sheriff-o-matic.appspot.com/alerts.

[Sergiy Byelozyorov, 2014-09-05 15:32:39]

Patchset #4 (id:60001) has been deleted

[Sergiy Byelozyorov, 2014-09-05 15:34:14]

All tests pass locally. Where is builder_alerts script running and how
frequently?

[Sergiy Byelozyorov, 2014-09-05 16:21:37]

Also - does it update itself or do I need to upload new version somehow?

[ojan, 2014-09-05 17:20:18]

On 2014/09/05 at 16:21:37, sergiyb wrote:
> Also - does it update itself or do I need to upload new version somehow?

It's running on a cron on an infra machine. It does update itself, so you
shouldn't need to do anything other than wait a few minutes for the cron to
finish once the dependent patch has landed.

[ojan, 2014-09-05 17:24:44]

On 2014/09/05 at 17:20:18, ojan-only-code-yellow-reviews wrote:
> On 2014/09/05 at 16:21:37, sergiyb wrote:
> > Also - does it update itself or do I need to upload new version somehow?
> 
> It's running on a cron on an infra machine. It does update itself, so you
shouldn't need to do anything other than wait a few minutes for the cron to
finish once the dependent patch has landed.

OIC, the dependent patch landed 3 hours ago and still hasn't been integrated it.
The cron last ran 5 minutes ago, so the cron is up and running. Maybe it's not
gclient syncing correctly. friedman, mind checking in on it? Is syncing failing?

[ojan, 2014-09-09 02:12:38]

On 2014/09/05 at 17:24:44, ojan-only-code-yellow-reviews wrote:
> On 2014/09/05 at 17:20:18, ojan-only-code-yellow-reviews wrote:
> > On 2014/09/05 at 16:21:37, sergiyb wrote:
> > > Also - does it update itself or do I need to upload new version somehow?
> > 
> > It's running on a cron on an infra machine. It does update itself, so you
shouldn't need to do anything other than wait a few minutes for the cron to
finish once the dependent patch has landed.
> 
> OIC, the dependent patch landed 3 hours ago and still hasn't been integrated
it. The cron last ran 5 minutes ago, so the cron is up and running. Maybe it's
not gclient syncing correctly. friedman, mind checking in on it? Is syncing
failing?

We finally resolve this today. The cron wasn't syncing correctly. Should be
fixed now. Looks like the json properly has the tree field now and you can land
this. You'll need to merge to tip of tree since the code has changed a bit.

[Sergiy Byelozyorov, 2014-09-09 14:14:51]

The CQ bit was checked by sergiyb@chromium.org

[commit-bot: I haz the power, 2014-09-09 14:15:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergiyb@chromium.org/511253004/80001

[commit-bot: I haz the power, 2014-09-09 15:22:31]

Committed patchset #4 (id:80001) as 181652