Fix static set_close_on_deactivate overriding non-virtual base method

Renamed the method and variable name in derived class so that the method in based class will not be overridden. 

BUG=270888
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233440

[noms (inactive), 2013-11-01 15:35:08]

Could you change the title of the issue to something more descriptive, like "Fix
static set_close_on_deactivate overriding non-virtual base method"? Also, could
you make your description a full sentence (start with a capital letter, end with
a period), please? Thanks!

[noms (inactive), 2013-11-04 16:00:24]

lgtm

[yao, 2013-11-04 16:08:40]

Hi Peter, 

Here's a small Cl that fix the name of a function & variable that originally
mask the non-virtual base method. Please take a look. 

Thanks!

[Peter Kasting, 2013-11-04 22:19:32]

LGTM

https://codereview.chromium.org/51113006/diff/20001/chrome/browser/ui/views/a...
File chrome/browser/ui/views/avatar_menu_bubble_view.h (right):

https://codereview.chromium.org/51113006/diff/20001/chrome/browser/ui/views/a...
chrome/browser/ui/views/avatar_menu_bubble_view.h:85: static void
set_close_on_deactivate_for_testing(bool close) {
If these functions are only for tests, and only called with "false" as an arg,
change them to "clear_close_on_deactivate_for_testing()" which takes no args. 
(All applicable files)

[yao, 2013-11-06 19:56:53]

https://codereview.chromium.org/51113006/diff/20001/chrome/browser/ui/views/a...
File chrome/browser/ui/views/avatar_menu_bubble_view.h (right):

https://codereview.chromium.org/51113006/diff/20001/chrome/browser/ui/views/a...
chrome/browser/ui/views/avatar_menu_bubble_view.h:85: static void
set_close_on_deactivate_for_testing(bool close) {
On 2013/11/04 22:19:33, Peter Kasting wrote:
> If these functions are only for tests, and only called with "false" as an arg,
> change them to "clear_close_on_deactivate_for_testing()" which takes no args. 
> (All applicable files)

Done.

[commit-bot: I haz the power, 2013-11-06 20:07:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yiyaoliu@chromium.org/51113006/180001

[commit-bot: I haz the power, 2013-11-07 00:48:39]

Change committed as 233440