chrome/browser/ui/views/avatar_menu_button_browsertest.cc - Issue 51113006: Fix static set_close_on_deactivate overriding non-virtual base method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/avatar_menu_button_browsertest.cc

Issue 51113006: Fix static set_close_on_deactivate overriding non-virtual base method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change function prototype from set_close_on_deactivate_for_testing(bool close) to clear_close_on_de… Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/avatar_menu_bubble_view.cc ('k') | chrome/browser/ui/views/new_avatar_menu_button_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/avatar_menu_button_browsertest.cc

diff --git a/chrome/browser/ui/views/avatar_menu_button_browsertest.cc b/chrome/browser/ui/views/avatar_menu_button_browsertest.cc

index 02f5cb33e84f51f8ed59e03ef65e4199dc7dff34..a7114fa532279a1abc285b215f3c7889ba0416ad 100644

--- a/chrome/browser/ui/views/avatar_menu_button_browsertest.cc

+++ b/chrome/browser/ui/views/avatar_menu_button_browsertest.cc

@@ -64,7 +64,7 @@ void AvatarMenuButtonTest::StartAvatarMenu() {

AvatarMenuButton* button = GetAvatarMenuButton();

ASSERT_TRUE(button);

- AvatarMenuBubbleView::set_close_on_deactivate(false);

+ AvatarMenuBubbleView::clear_close_on_deactivate_for_testing();

static_cast<views::MenuButtonListener*>(button)->OnMenuButtonClicked(

NULL, gfx::Point());

base::MessageLoop::current()->RunUntilIdle();