Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
510993002:
Fix the context menu positioning for ExtensionOptionsGuest (Closed)
DescriptionFix the context menu positioning for ExtensionOptionsGuest
Implement HandleContextMenu in ExtensionOptionsGuest so that the right
click context menu within guest views are properly positioned next to
the pointer.
BUG=406885
Committed: https://crrev.com/c1f65d4b57000fa395d501379cd906f9ea5833e6
Cr-Commit-Position: refs/heads/master@{#292314}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 25 (0 generated)
ericzeng@chromium.org changed reviewers: + fsamuel@chromium.org, kalman@chromium.org
PTAL
https://codereview.chromium.org/510993002/diff/1/chrome/browser/guest_view/ex... File chrome/browser/guest_view/extension_options/extension_options_guest.cc (right): https://codereview.chromium.org/510993002/diff/1/chrome/browser/guest_view/ex... chrome/browser/guest_view/extension_options/extension_options_guest.cc:199: const content::ContextMenuParams& params) { Could you move this code to GuestViewBase, and delete it here and in AppViewGuest? WebViewGuest does its own implementation.
https://codereview.chromium.org/510993002/diff/1/chrome/browser/guest_view/ex... File chrome/browser/guest_view/extension_options/extension_options_guest.cc (right): https://codereview.chromium.org/510993002/diff/1/chrome/browser/guest_view/ex... chrome/browser/guest_view/extension_options/extension_options_guest.cc:199: const content::ContextMenuParams& params) { On 2014/08/27 22:19:10, Fady Samuel wrote: > Could you move this code to GuestViewBase, and delete it here and in > AppViewGuest? WebViewGuest does its own implementation. Actually, nm, I forgot GuestViewBase moved to extensions :P That doesn't work. LGTM.
The CQ bit was checked by ericzeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/510993002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
The CQ bit was checked by ericzeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/510993002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by ericzeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/510993002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by ericzeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/510993002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by ericzeng@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/510993002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as e64527932bb818f7d0defda4129e7b0f65b28c5c
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c1f65d4b57000fa395d501379cd906f9ea5833e6 Cr-Commit-Position: refs/heads/master@{#292314} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
