Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1843)

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.cc

Issue 510993002: Fix the context menu positioning for ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guest_view/extension_options/extension_options_guest.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.cc b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
index 1e1866b25c8d9db082d1241109a10abe1eaadb75..90d79e3b5e65dba7ab32e64834bd88ad6b334bfb 100644
--- a/chrome/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/guest_view/extension_options/extension_options_constants.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_window.h"
@@ -16,6 +17,7 @@
#include "chrome/common/extensions/api/extension_options_internal.h"
#include "chrome/common/extensions/manifest_url_handler.h"
#include "components/crx_file/id_util.h"
+#include "components/renderer_context_menu/context_menu_delegate.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/site_instance.h"
#include "content/public/browser/web_contents.h"
@@ -193,6 +195,18 @@ void ExtensionOptionsGuest::CloseContents(content::WebContents* source) {
make_scoped_ptr(new base::DictionaryValue())));
}
+bool ExtensionOptionsGuest::HandleContextMenu(
+ const content::ContextMenuParams& params) {
Fady Samuel 2014/08/27 22:19:10 Could you move this code to GuestViewBase, and del
Fady Samuel 2014/08/27 22:19:54 Actually, nm, I forgot GuestViewBase moved to exte
+ ContextMenuDelegate* menu_delegate =
+ ContextMenuDelegate::FromWebContents(guest_web_contents());
+ DCHECK(menu_delegate);
+
+ scoped_ptr<RenderViewContextMenu> menu =
+ menu_delegate->BuildMenu(guest_web_contents(), params);
+ menu_delegate->ShowMenu(menu.Pass());
+ return true;
+}
+
bool ExtensionOptionsGuest::ShouldCreateWebContents(
content::WebContents* web_contents,
int route_id,
« no previous file with comments | « chrome/browser/guest_view/extension_options/extension_options_guest.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698