Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 510953003: Revert of Adding Select Action Bar Unit test case for input (Closed)

Created:
6 years, 3 months ago by awong
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding Select Action Bar Unit test case for input (patchset #3 of https://codereview.chromium.org/506423003/) Reason for revert: See previous review message. Original issue's description: > [Android] Add unit tests for SelectActionBar appearance > > The SelectActionBar currently lacks test coverage. Add several test > cases covering the appearance of the bar when interacting with an input > field. > > Committed: https://chromium.googlesource.com/chromium/src/+/0bc56569817a24acea46748c599d77b59157d84d TBR=jdduke@chromium.org,aurimas@chromium.org,ajith.v@samsung.com NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c58501b7feb5b3e83e889645e7550c0bb28e6544 Cr-Commit-Position: refs/heads/master@{#292252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
awong
Created Revert of Adding Select Action Bar Unit test case for input
6 years, 3 months ago (2014-08-27 22:47:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/510953003/1
6 years, 3 months ago (2014-08-27 22:48:24 UTC) #2
awong
The CQ bit was unchecked by ajwong@chromium.org
6 years, 3 months ago (2014-08-27 22:50:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 104e6ba4498893e1cf0bc2389806cf4f428d145f
6 years, 3 months ago (2014-08-27 22:53:01 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:55:05 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c58501b7feb5b3e83e889645e7550c0bb28e6544
Cr-Commit-Position: refs/heads/master@{#292252}

Powered by Google App Engine
This is Rietveld 408576698