Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 510953002: Can't hurt to make this SkNoncopyable. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Can't hurt to make this SkNoncopyable. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ee36952c601723a7069b8c2fc200dd769b8db1b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkRecords.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
mtklein@google.com changed reviewers: + bungeman@google.com, mtklein@google.com
6 years, 3 months ago (2014-08-27 19:34:27 UTC) #1
mtklein
6 years, 3 months ago (2014-08-27 19:34:27 UTC) #2
bungeman-skia
lgtm
6 years, 3 months ago (2014-08-27 19:50:51 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 3 months ago (2014-08-27 19:54:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/510953002/1
6 years, 3 months ago (2014-08-27 19:55:18 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-27 20:02:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as ee36952c601723a7069b8c2fc200dd769b8db1b0

Powered by Google App Engine
This is Rietveld 408576698