src/core/SkRecords.h - Issue 510953002: Can't hurt to make this SkNoncopyable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkRecords.h

Issue 510953002: Can't hurt to make this SkNoncopyable. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkRecords.h

diff --git a/src/core/SkRecords.h b/src/core/SkRecords.h

index f216897dca30e016af1339415ae8ca07df554204..bd65fc5cb6fbe1b53308d43806e3fef37aeae937 100644

--- a/src/core/SkRecords.h

+++ b/src/core/SkRecords.h

@@ -180,7 +180,7 @@ private:

// Like SkBitmap, but deep copies pixels if they're not immutable.

// Using this, we guarantee the immutability of all bitmaps we record.

-class ImmutableBitmap {

+class ImmutableBitmap : SkNoncopyable {

public:

explicit ImmutableBitmap(const SkBitmap& bitmap) {

if (bitmap.isImmutable()) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »