Register granting of previously withheld permissions as a permissions

chrome/browser/extensions/crx_installer.cc

Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index ec7ce8a5e09ad9c528a1917157076ce5df48f3eb..d3736ee900466ecd9fc50780aeab95b160892b1a 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -803,6 +803,7 @@ void CrxInstaller::ReportSuccessFromUIThread() {
     // this silently.
     if ((client_ || allow_silent_install_) && grant_permissions_) {
       PermissionsUpdater perms_updater(profile());
+      perms_updater.InitializePermissions(extension());

[not at google - send to devlin, 2014/08/28 03:18:46]

Can we do this when extension() gets created?

[gpdavis, 2014/08/28 19:02:39]

Looks like this gets created in sandboxed_unpacker.cc (or in a couple of other
places within this class for special situations), and there doesn't appear to be
any way to get a profile to pass to the permissions updater.

However, the extension gets passed back into this class through OnUnpackSuccess,
and then set_extension is called on install_checker_ (extension() returns
install_checker_.extension().get()), so we could initialize the permissions
there.
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

OnUnpackSuccess seems to be the common denominator for all the cases of
extension creation here.  Extensions created by user scripts get passed in here
as well.  So I feel like if we want to minimize Initialize calls, we should
either do it here or in OnUnpackSuccess.

Thoughts?

       perms_updater.GrantActivePermissions(extension());
     }
   }