Register granting of previously withheld permissions as a permissions

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 785 matching lines @@
   if (!update_from_settings_page_) {
     // If there is a client, tell the client about installation.
     if (client_)
       client_->OnInstallSuccess(extension(), install_icon_.get());
 
     // We update the extension's granted permissions if the user already
     // approved the install (client_ is non NULL), or we are allowed to install
     // this silently.
     if ((client_ || allow_silent_install_) && grant_permissions_) {
       PermissionsUpdater perms_updater(profile());
+      perms_updater.InitializePermissions(extension());

[not at google - send to devlin, 2014/08/28 03:18:46]

Can we do this when extension() gets created?

[gpdavis, 2014/08/28 19:02:39]

Looks like this gets created in sandboxed_unpacker.cc (or in a couple of other
places within this class for special situations), and there doesn't appear to be
any way to get a profile to pass to the permissions updater.

However, the extension gets passed back into this class through OnUnpackSuccess,
and then set_extension is called on install_checker_ (extension() returns
install_checker_.extension().get()), so we could initialize the permissions
there.
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

OnUnpackSuccess seems to be the common denominator for all the cases of
extension creation here.  Extensions created by user scripts get passed in here
as well.  So I feel like if we want to minimize Initialize calls, we should
either do it here or in OnUnpackSuccess.

Thoughts?

       perms_updater.GrantActivePermissions(extension());
     }
   }
 
   service_weak_->OnExtensionInstalled(
       extension(), page_ordinal_, install_flags_);
   NotifyCrxInstallComplete(true);
 }
 
 void CrxInstaller::NotifyCrxInstallBegin() {
@@ skipping 76 matching lines @@
   if (!prefs->DidExtensionEscalatePermissions(extension()->id()))
     return;
 
   if (client_) {
     AddRef();  // Balanced in InstallUIProceed() and InstallUIAbort().
     client_->ConfirmReEnable(this, extension());
   }
 }
 
 }  // namespace extensions