Rename AutocompleteProviderDelegate to AutocompleteProviderClient

Committed: https://crrev.com/884ad197db2dd93253957c089cd583b8fca4802d
Cr-Commit-Position: refs/heads/master@{#292333}

[hashimoto, 2014-08-27 11:11:39]

Patchset #1 (id:1) has been deleted

[hashimoto, 2014-08-27 11:14:49]

hashimoto@chromium.org changed reviewers:
+ blundell@chromium.org

[hashimoto, 2014-08-27 11:15:24]

hashimoto@chromium.org changed reviewers:
+ pkasting@google.com
- blundell@chromium.org

[hashimoto, 2014-08-27 11:15:24]

Oops, sending for a wrong reviewer.
Peter, could you take a look at this change?

[hashimoto, 2014-08-27 11:25:19]

hashimoto@chromium.org changed reviewers:
+ pkasting@chromium.org
- pkasting@google.com

[blundell, 2014-08-27 12:26:24]

blundell@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2014-08-27 12:26:25]

I appreciate this change, thanks!

[Peter Kasting, 2014-08-27 19:45:23]

RS LGTM

[hashimoto, 2014-08-28 03:13:30]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-28 03:14:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/510783002/40001

[commit-bot: I haz the power, 2014-08-28 03:56:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47388)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/52743)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-28 03:57:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 03:57:42]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[hashimoto, 2014-08-28 04:06:55]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-28 04:08:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/510783002/60001

[commit-bot: I haz the power, 2014-08-28 05:29:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 05:29:54]

Failed to apply patch for
chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.cc:16
  error: chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.cc:
patch does not apply

Patch:   NR 
chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.cc->chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
Index: chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
diff --git
a/chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.cc
b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
similarity index 76%
rename from chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.cc
rename to chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
index
e99e16c220e620c2dd80f59ed3c39f642bd5a78b..b0f88c8557692402019b649d17d542d898ae29ad
100644
--- a/chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.cc
+++ b/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.h"
+#include "chrome/browser/autocomplete/chrome_autocomplete_provider_client.h"
 
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/autocomplete/autocomplete_classifier.h"
@@ -16,42 +16,42 @@
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/common/pref_names.h"
 
-ChromeAutocompleteProviderDelegate::ChromeAutocompleteProviderDelegate(
+ChromeAutocompleteProviderClient::ChromeAutocompleteProviderClient(
     Profile* profile)
     : profile_(profile),
       scheme_classifier_(profile) {
 }
 
-ChromeAutocompleteProviderDelegate::~ChromeAutocompleteProviderDelegate() {
+ChromeAutocompleteProviderClient::~ChromeAutocompleteProviderClient() {
 }
 
 net::URLRequestContextGetter*
-ChromeAutocompleteProviderDelegate::RequestContext() {
+ChromeAutocompleteProviderClient::RequestContext() {
   return profile_->GetRequestContext();
 }
 
-bool ChromeAutocompleteProviderDelegate::IsOffTheRecord() {
+bool ChromeAutocompleteProviderClient::IsOffTheRecord() {
   return profile_->IsOffTheRecord();
 }
 
-std::string ChromeAutocompleteProviderDelegate::AcceptLanguages() {
+std::string ChromeAutocompleteProviderClient::AcceptLanguages() {
   return profile_->GetPrefs()->GetString(prefs::kAcceptLanguages);
 }
 
-bool ChromeAutocompleteProviderDelegate::SearchSuggestEnabled() {
+bool ChromeAutocompleteProviderClient::SearchSuggestEnabled() {
   return profile_->GetPrefs()->GetBoolean(prefs::kSearchSuggestEnabled);
 }
 
-bool ChromeAutocompleteProviderDelegate::ShowBookmarkBar() {
+bool ChromeAutocompleteProviderClient::ShowBookmarkBar() {
   return profile_->GetPrefs()->GetBoolean(prefs::kShowBookmarkBar);
 }
 
 const AutocompleteSchemeClassifier&
-ChromeAutocompleteProviderDelegate::SchemeClassifier() {
+ChromeAutocompleteProviderClient::SchemeClassifier() {
   return scheme_classifier_;
 }
 
-void ChromeAutocompleteProviderDelegate::Classify(
+void ChromeAutocompleteProviderClient::Classify(
     const base::string16& text,
     bool prefer_keyword,
     bool allow_exact_keyword_match,
@@ -65,21 +65,20 @@ void ChromeAutocompleteProviderDelegate::Classify(
                        page_classification, match, alternate_nav_url);
 }
 
-history::URLDatabase* ChromeAutocompleteProviderDelegate::InMemoryDatabase() {
+history::URLDatabase* ChromeAutocompleteProviderClient::InMemoryDatabase() {
   HistoryService* history_service =
       HistoryServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
   return history_service ? history_service->InMemoryDatabase() : NULL;
 }
 
-void
-ChromeAutocompleteProviderDelegate::DeleteMatchingURLsForKeywordFromHistory(
+void ChromeAutocompleteProviderClient::DeleteMatchingURLsForKeywordFromHistory(
     history::KeywordID keyword_id,
     const base::string16& term) {
   HistoryServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS)
       ->DeleteMatchingURLsForKeyword(keyword_id, term);
 }
 
-bool ChromeAutocompleteProviderDelegate::TabSyncEnabledAndUnencrypted() {
+bool ChromeAutocompleteProviderClient::TabSyncEnabledAndUnencrypted() {
   // Check field trials and settings allow sending the URL on suggest requests.
   ProfileSyncService* service =
       ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile_);
@@ -91,7 +90,7 @@ bool
ChromeAutocompleteProviderDelegate::TabSyncEnabledAndUnencrypted() {
       !service->GetEncryptedDataTypes().Has(syncer::SESSIONS);
 }
 
-void ChromeAutocompleteProviderDelegate::PrefetchImage(const GURL& url) {
+void ChromeAutocompleteProviderClient::PrefetchImage(const GURL& url) {
   BitmapFetcherService* image_service =
       BitmapFetcherServiceFactory::GetForBrowserContext(profile_);
   DCHECK(image_service);

[hashimoto, 2014-08-28 05:54:55]

Committed patchset #4 (id:80001) to pending queue manually as 30f7c99 (presubmit
successful).

[commit-bot: I haz the power, 2014-09-10 02:57:59]

Patchset 4 (id:??) landed as
https://crrev.com/884ad197db2dd93253957c089cd583b8fca4802d
Cr-Commit-Position: refs/heads/master@{#292333}