Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: chrome/browser/autocomplete/zero_suggest_provider.cc

Issue 510783002: Rename AutocompleteProviderDelegate to AutocompleteProviderClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/autocomplete/search_provider_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autocomplete/zero_suggest_provider.h" 5 #include "chrome/browser/autocomplete/zero_suggest_provider.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/i18n/case_conversion.h" 8 #include "base/i18n/case_conversion.h"
9 #include "base/json/json_string_value_serializer.h" 9 #include "base/json/json_string_value_serializer.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
11 #include "base/metrics/user_metrics.h" 11 #include "base/metrics/user_metrics.h"
12 #include "base/prefs/pref_service.h" 12 #include "base/prefs/pref_service.h"
13 #include "base/strings/string16.h" 13 #include "base/strings/string16.h"
14 #include "base/strings/string_util.h" 14 #include "base/strings/string_util.h"
15 #include "base/strings/utf_string_conversions.h" 15 #include "base/strings/utf_string_conversions.h"
16 #include "base/time/time.h" 16 #include "base/time/time.h"
17 #include "chrome/browser/autocomplete/autocomplete_classifier.h" 17 #include "chrome/browser/autocomplete/autocomplete_classifier.h"
18 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h" 18 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"
19 #include "chrome/browser/autocomplete/chrome_autocomplete_provider_delegate.h" 19 #include "chrome/browser/autocomplete/chrome_autocomplete_provider_client.h"
20 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h" 20 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
21 #include "chrome/browser/autocomplete/history_url_provider.h" 21 #include "chrome/browser/autocomplete/history_url_provider.h"
22 #include "chrome/browser/history/history_types.h" 22 #include "chrome/browser/history/history_types.h"
23 #include "chrome/browser/history/top_sites.h" 23 #include "chrome/browser/history/top_sites.h"
24 #include "chrome/browser/profiles/profile.h" 24 #include "chrome/browser/profiles/profile.h"
25 #include "chrome/common/pref_names.h" 25 #include "chrome/common/pref_names.h"
26 #include "components/metrics/proto/omnibox_input_type.pb.h" 26 #include "components/metrics/proto/omnibox_input_type.pb.h"
27 #include "components/omnibox/autocomplete_input.h" 27 #include "components/omnibox/autocomplete_input.h"
28 #include "components/omnibox/autocomplete_match.h" 28 #include "components/omnibox/autocomplete_match.h"
29 #include "components/omnibox/autocomplete_provider_listener.h" 29 #include "components/omnibox/autocomplete_provider_listener.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 base::string16 prefix; 112 base::string16 prefix;
113 TemplateURLRef::SearchTermsArgs search_term_args(prefix); 113 TemplateURLRef::SearchTermsArgs search_term_args(prefix);
114 GURL suggest_url(default_provider->suggestions_url_ref().ReplaceSearchTerms( 114 GURL suggest_url(default_provider->suggestions_url_ref().ReplaceSearchTerms(
115 search_term_args, template_url_service_->search_terms_data())); 115 search_term_args, template_url_service_->search_terms_data()));
116 if (!suggest_url.is_valid()) 116 if (!suggest_url.is_valid())
117 return; 117 return;
118 118
119 // No need to send the current page URL in personalized suggest field trial. 119 // No need to send the current page URL in personalized suggest field trial.
120 if (CanSendURL(input.current_url(), suggest_url, default_provider, 120 if (CanSendURL(input.current_url(), suggest_url, default_provider,
121 current_page_classification_, 121 current_page_classification_,
122 template_url_service_->search_terms_data(), delegate_.get()) && 122 template_url_service_->search_terms_data(), client_.get()) &&
123 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial()) { 123 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial()) {
124 // Update suggest_url to include the current_page_url. 124 // Update suggest_url to include the current_page_url.
125 search_term_args.current_page_url = current_query_; 125 search_term_args.current_page_url = current_query_;
126 suggest_url = GURL(default_provider->suggestions_url_ref(). 126 suggest_url = GURL(default_provider->suggestions_url_ref().
127 ReplaceSearchTerms( 127 ReplaceSearchTerms(
128 search_term_args, 128 search_term_args,
129 template_url_service_->search_terms_data())); 129 template_url_service_->search_terms_data()));
130 } else if (!CanShowZeroSuggestWithoutSendingURL(suggest_url, 130 } else if (!CanShowZeroSuggestWithoutSendingURL(suggest_url,
131 input.current_url())) { 131 input.current_url())) {
132 return; 132 return;
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 // |field_trial_triggered_in_session_| unchanged and set 178 // |field_trial_triggered_in_session_| unchanged and set
179 // |field_trial_triggered_| to false since zero suggest is inactive now. 179 // |field_trial_triggered_| to false since zero suggest is inactive now.
180 field_trial_triggered_ = false; 180 field_trial_triggered_ = false;
181 } 181 }
182 182
183 ZeroSuggestProvider::ZeroSuggestProvider( 183 ZeroSuggestProvider::ZeroSuggestProvider(
184 AutocompleteProviderListener* listener, 184 AutocompleteProviderListener* listener,
185 TemplateURLService* template_url_service, 185 TemplateURLService* template_url_service,
186 Profile* profile) 186 Profile* profile)
187 : BaseSearchProvider(template_url_service, 187 : BaseSearchProvider(template_url_service,
188 scoped_ptr<AutocompleteProviderDelegate>( 188 scoped_ptr<AutocompleteProviderClient>(
189 new ChromeAutocompleteProviderDelegate(profile)), 189 new ChromeAutocompleteProviderClient(profile)),
190 AutocompleteProvider::TYPE_ZERO_SUGGEST), 190 AutocompleteProvider::TYPE_ZERO_SUGGEST),
191 listener_(listener), 191 listener_(listener),
192 profile_(profile), 192 profile_(profile),
193 results_from_cache_(false), 193 results_from_cache_(false),
194 weak_ptr_factory_(this) { 194 weak_ptr_factory_(this) {
195 } 195 }
196 196
197 ZeroSuggestProvider::~ZeroSuggestProvider() { 197 ZeroSuggestProvider::~ZeroSuggestProvider() {
198 } 198 }
199 199
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 results_.verbatim_relevance : kDefaultVerbatimZeroSuggestRelevance; 424 results_.verbatim_relevance : kDefaultVerbatimZeroSuggestRelevance;
425 } 425 }
426 426
427 bool ZeroSuggestProvider::CanShowZeroSuggestWithoutSendingURL( 427 bool ZeroSuggestProvider::CanShowZeroSuggestWithoutSendingURL(
428 const GURL& suggest_url, 428 const GURL& suggest_url,
429 const GURL& current_page_url) const { 429 const GURL& current_page_url) const {
430 if (!ZeroSuggestEnabled(suggest_url, 430 if (!ZeroSuggestEnabled(suggest_url,
431 template_url_service_->GetDefaultSearchProvider(), 431 template_url_service_->GetDefaultSearchProvider(),
432 current_page_classification_, 432 current_page_classification_,
433 template_url_service_->search_terms_data(), 433 template_url_service_->search_terms_data(),
434 delegate_.get())) 434 client_.get()))
435 return false; 435 return false;
436 436
437 // If we cannot send URLs, then only the MostVisited and Personalized 437 // If we cannot send URLs, then only the MostVisited and Personalized
438 // variations can be shown. 438 // variations can be shown.
439 if (!OmniboxFieldTrial::InZeroSuggestMostVisitedFieldTrial() && 439 if (!OmniboxFieldTrial::InZeroSuggestMostVisitedFieldTrial() &&
440 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial()) 440 !OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial())
441 return false; 441 return false;
442 442
443 // Only show zero suggest for HTTP[S] pages. 443 // Only show zero suggest for HTTP[S] pages.
444 // TODO(mariakhomenko): We may be able to expand this set to include pages 444 // TODO(mariakhomenko): We may be able to expand this set to include pages
(...skipping 16 matching lines...) Expand all
461 if (!json_data.empty()) { 461 if (!json_data.empty()) {
462 scoped_ptr<base::Value> data( 462 scoped_ptr<base::Value> data(
463 SearchSuggestionParser::DeserializeJsonData(json_data)); 463 SearchSuggestionParser::DeserializeJsonData(json_data));
464 if (data && ParseSuggestResults( 464 if (data && ParseSuggestResults(
465 *data, kDefaultZeroSuggestRelevance, false, &results_)) { 465 *data, kDefaultZeroSuggestRelevance, false, &results_)) {
466 ConvertResultsToAutocompleteMatches(); 466 ConvertResultsToAutocompleteMatches();
467 results_from_cache_ = !matches_.empty(); 467 results_from_cache_ = !matches_.empty();
468 } 468 }
469 } 469 }
470 } 470 }
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete/search_provider_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698