Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 510663002: PepperWebSocketHost should not call blink::WebSocket APIs after closed. (Closed)

Created:
6 years, 3 months ago by yhirano
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PepperWebSocketHost should not call blink::WebSocket APIs after closed. blink::WebSocket assumes that any APIs won't be called once disconnect is called, but PepperWebSocketHost didn't keep the contract. Note that PepperWebSocketHost can receive SEND* / CLOSE messages even if it sends a CLOSED message to the ppapi process, because these IPCs are asynchronous. BUG=407885 R=ricea@chromium.org Committed: https://crrev.com/c411803acfaca9e2628f4ab937b738395ad8030f Cr-Commit-Position: refs/heads/master@{#292167}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/pepper_websocket_host.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/tests/test_websocket.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_websocket.cc View 2 chunks +28 lines, -0 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
yhirano
6 years, 3 months ago (2014-08-27 04:44:06 UTC) #1
Adam Rice
lgtm https://codereview.chromium.org/510663002/diff/1/ppapi/tests/test_websocket.cc File ppapi/tests/test_websocket.cc (right): https://codereview.chromium.org/510663002/diff/1/ppapi/tests/test_websocket.cc#newcode1181 ppapi/tests/test_websocket.cc:1181: for (size_t i = 0; i < 10000; ...
6 years, 3 months ago (2014-08-27 05:58:57 UTC) #2
yhirano
yhirano@chromium.org changed reviewers: + dmichael@chromium.org
6 years, 3 months ago (2014-08-27 07:06:33 UTC) #3
yhirano
+dmichael for OWNER review. https://codereview.chromium.org/510663002/diff/1/ppapi/tests/test_websocket.cc File ppapi/tests/test_websocket.cc (right): https://codereview.chromium.org/510663002/diff/1/ppapi/tests/test_websocket.cc#newcode1181 ppapi/tests/test_websocket.cc:1181: for (size_t i = 0; ...
6 years, 3 months ago (2014-08-27 07:06:33 UTC) #4
dmichael (off chromium)
lgtm
6 years, 3 months ago (2014-08-27 14:51:31 UTC) #5
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 3 months ago (2014-08-27 14:57:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/510663002/1
6 years, 3 months ago (2014-08-27 14:58:00 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 15:51:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0917fe5b17ac904f14ce8c3ccd844fed3c733199
6 years, 3 months ago (2014-08-27 16:47:36 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c411803acfaca9e2628f4ab937b738395ad8030f
Cr-Commit-Position: refs/heads/master@{#292167}

Powered by Google App Engine
This is Rietveld 408576698