content/renderer/pepper/pepper_websocket_host.cc - Issue 510663002: PepperWebSocketHost should not call blink::WebSocket APIs after closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_websocket_host.cc

Issue 510663002: PepperWebSocketHost should not call blink::WebSocket APIs after closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/pepper_websocket_host.cc

diff --git a/content/renderer/pepper/pepper_websocket_host.cc b/content/renderer/pepper/pepper_websocket_host.cc

index 9b74ccc2dc5fab07429d63bfa5c346f7ee1158a7..6b55bb6975b99f1ca054ffe2934ea5b524f1df1c 100644

--- a/content/renderer/pepper/pepper_websocket_host.cc

+++ b/content/renderer/pepper/pepper_websocket_host.cc

@@ -194,8 +194,10 @@ void PepperWebSocketHost::didClose(unsigned long unhandled_buffered_amount,

}

// Disconnect.

- if (websocket_)

+ if (websocket_) {

websocket_->disconnect();

+ websocket_.reset();

+ }

}

int32_t PepperWebSocketHost::OnHostMsgConnect(

« no previous file with comments | « chrome/test/ppapi/ppapi_browsertest.cc ('k') | ppapi/tests/test_websocket.h » ('j') | ppapi/tests/test_websocket.cc » ('J')