Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 510563002: Remove implicit conversions from scoped_refptr to T* in base/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org, Ilya Sherman, tfarina, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in base/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/d81e7d7e92f955cc80cc627682db05a24f994bf1 Cr-Commit-Position: refs/heads/master@{#292050}

Patch Set 1 #

Patch Set 2 : Trim stl_util.h #

Patch Set 3 : Propagate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -47 lines) Patch
M base/debug/trace_event_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/files/important_file_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/field_trial_unittest.cc View 1 2 32 chunks +52 lines, -42 lines 0 comments Download
M base/prefs/json_pref_store.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + willchan@chromium.org
6 years, 3 months ago (2014-08-26 23:17:41 UTC) #1
dcheng
This is the last-ish major CL (though it turns out the clang tool mishandles base/stl_util.h's ...
6 years, 3 months ago (2014-08-26 23:17:41 UTC) #2
willchan no longer on Chromium
lgtm
6 years, 3 months ago (2014-08-26 23:18:37 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 23:19:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/510563002/40001
6 years, 3 months ago (2014-08-26 23:21:35 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (40001) as c6fd564f05db1e369a77ba30644ee7ea912d6092
6 years, 3 months ago (2014-08-27 00:23:38 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:05 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d81e7d7e92f955cc80cc627682db05a24f994bf1
Cr-Commit-Position: refs/heads/master@{#292050}

Powered by Google App Engine
This is Rietveld 408576698